-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(addon-mobile): virtual-scroll flickers during scroll in zoneless mode #10023
base: main
Are you sure you want to change the base?
Conversation
Failed tests ❌Before (main) ← Diff → After (local)tests-addon-mobile-mobile--a1e65-e-user-agent-InputDateMulti-chromium-retry2/02-input-date-range-mobile-1.diff.pngtests-addon-mobile-mobile--bf2eb-mobile-user-agent-InputDate-chromium-retry2/03-input-date-range-mobile-1.diff.pngtests-addon-mobile-mobile--77c1d-dar.pw-MobileCalendar-works-chromium-retry2/01-mobile-calendar.diff.pngtests-addon-mobile-mobile--f9803-e-user-agent-InputDateRange-chromium-retry2/01-input-date-range-mobile-1.diff.pngtests-addon-mobile-mobile--77c1d-dar.pw-MobileCalendar-works-webkit-retry2/01-mobile-calendar.diff.pngtests-addon-mobile-mobile--a1e65-e-user-agent-InputDateMulti-webkit-retry2/02-input-date-range-mobile-1.diff.pngtests-addon-mobile-mobile--bf2eb-mobile-user-agent-InputDate-webkit-retry2/03-input-date-range-mobile-1.diff.pngtests-addon-mobile-mobile--f9803-e-user-agent-InputDateRange-webkit-retry2/01-input-date-range-mobile-1.diff.pngtests-legacy-input-date-in-0eb0a-e-mobile-calendar---spanish-chromium-retry2/08-input-date-spanish.diff.pngtests-legacy-input-date-in-824cc-e-mobile-calendar---english-chromium-retry2/08-input-date-english.diff.pngtests-legacy-input-date-in-b42f6-e-mobile-calendar---russian-chromium-retry2/08-input-date-russian.diff.pngtests-legacy-input-date-in-0eb0a-e-mobile-calendar---spanish-webkit-retry2/08-input-date-spanish.diff.pngtests-legacy-input-date-in-b42f6-e-mobile-calendar---russian-webkit-retry2/08-input-date-russian.diff.pngtests-legacy-input-date-in-824cc-e-mobile-calendar---english-webkit-retry2/08-input-date-english.diff.png(updated for commit 5f83f62) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10023 +/- ##
=======================================
Coverage 66.13% 66.13%
=======================================
Files 1215 1215
Lines 15720 15720
Branches 2254 2267 +13
=======================================
Hits 10397 10397
- Misses 5124 5168 +44
+ Partials 199 155 -44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Visit the preview URL for this PR (updated for commit 5f83f62): https://taiga-previews-demo--pr10023-splincode-fix-issues-9662-wotaopxq.web.app (expires Thu, 19 Dec 2024 14:52:35 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37 |
BundleMonUnchanged files (5)
Total files change +1B 0% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
54152ab
to
3160ce2
Compare
3160ce2
to
5f83f62
Compare
Playwright test results 16 failed Details Open report ↗︎ Failed testschromium › tests/addon-mobile/mobile-calendar/input-date.pw.spec.ts › InputDate and mobile user agent › InputDateRange Flaky testswebkit › tests/core/data-list/data-list.pw.spec.ts › DataList › Options with long text Skipped testswebkit › tests/addon-commerce/input-card-group.pw.spec.ts › InputCardGroup › Examples › input card grouped with validation |
Fixes #9662
Before
Screen.Recording.2024-12-18.at.3.17.51.PM.mov
After
Screen.Recording.2024-12-18.at.3.10.29.PM.mov