Skip to content

Commit

Permalink
fix(addon-mobile): virtual-scroll flickers during scroll in zoneless …
Browse files Browse the repository at this point in the history 
…mode
  • Loading branch information
@splincode
splincode committed Dec 23, 2024
1 parent c12ceaa commit 8615133
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
4 changes: 4 additions & 0 deletions projects/addon-mobile/components/mobile-calendar/mobile-calendar.style.less
View file
Original file line number Diff line number Diff line change
Expand Up @@ -177,11 +177,15 @@
}

.t-month-wrapper {
display: flex;
margin: 0.625rem 0 -0.625rem;
block-size: 22.125rem; // itemSize: 354px;
flex-direction: column;
}

.t-month {
block-size: 2.75rem;
inline-size: 100%;
line-height: 2.75rem;
padding-left: 1rem;
font-size: 0.875rem;
Expand Down
3 changes: 3 additions & 0 deletions projects/addon-mobile/components/mobile-calendar/mobile-calendar.template.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@
</div>
<cdk-virtual-scroll-viewport
#monthsScrollRef
itemSize="354"
maxBufferPx="5000"
minBufferPx="0"
class="t-months"
(scrolledIndexChange)="onMonthChange($event)"
>
Expand Down
2 changes: 1 addition & 1 deletion projects/demo-playwright/tests/legacy/input-date-range/input-date-range.pw.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ test.describe('InputDateRange', () => {
await mobileCalendar.confirmButton.click();

await expect(inputDateRange.textfield).toHaveValue(

Check failure on line 263 in projects/demo-playwright/tests/legacy/input-date-range/input-date-range.pw.spec.ts

View workflow job for this annotation

GitHub Actions / Playwright / ubuntu-latest / 7 of 9

[chromium] › tests/legacy/input-date-range/input-date-range.pw.spec.ts:252:17 › InputDateRange › API › Mobile emulation › Selection of only single date produces range with the same start and end 

  4) [chromium] › tests/legacy/input-date-range/input-date-range.pw.spec.ts:252:17 › InputDateRange › API › Mobile emulation › Selection of only single date produces range with the same start and end 
    Error: Timed out 5000ms waiting for expect(locator).toHaveValue(expected)

    Locator: locator('#demo-content').locator('tui-input-date-range').getByRole('textbox')
    Expected string: "17.09.2020 – 17.09.2020"
    Received string: "17.08.2020 – 17.08.2020"
    Call log:
      - expect.toHaveValue with timeout 5000ms
      - waiting for locator('#demo-content').locator('tui-input-date-range').getByRole('textbox')
        9 × locator resolved to <input tabindex="0" inputmode="" placeholder="" aria-invalid="false" _ngcontent-ng-c3831396199="" id="tui_interactive_431601061540000" class="t-input ng-untouched ng-pristine ng-valid" automation-id="tui-primitive-textfield__native-input"/>
          - unexpected value "17.08.2020 – 17.08.2020"


      261 |                 await mobileCalendar.confirmButton.click();
      262 |
    > 263 |                 await expect(inputDateRange.textfield).toHaveValue(
          |                                                        ^
      264 |                     `17.09.2020${CHAR_NO_BREAK_SPACE}–${CHAR_NO_BREAK_SPACE}17.09.2020`,
      265 |                 );
      266 |             });
        at /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests/legacy/input-date-range/input-date-range.pw.spec.ts:263:56

Check failure on line 263 in projects/demo-playwright/tests/legacy/input-date-range/input-date-range.pw.spec.ts

View workflow job for this annotation

GitHub Actions / Playwright / macos-latest / 7 of 9

[webkit] › tests/legacy/input-date-range/input-date-range.pw.spec.ts:252:17 › InputDateRange › API › Mobile emulation › Selection of only single date produces range with the same start and end 

  4) [webkit] › tests/legacy/input-date-range/input-date-range.pw.spec.ts:252:17 › InputDateRange › API › Mobile emulation › Selection of only single date produces range with the same start and end 
    Error: Timed out 5000ms waiting for expect(locator).toHaveValue(expected)

    Locator: locator('#demo-content').locator('tui-input-date-range').getByRole('textbox')
    Expected string: "17.09.2020 – 17.09.2020"
    Received string: "17.08.2020 – 17.08.2020"
    Call log:
      - expect.toHaveValue with timeout 5000ms
      - waiting for locator('#demo-content').locator('tui-input-date-range').getByRole('textbox')
        9 × locator resolved to <input tabindex="0" inputmode="" placeholder="" aria-invalid="false" _ngcontent-ng-c3831396199="" id="tui_interactive_431601061540000" class="t-input ng-untouched ng-pristine ng-valid" automation-id="tui-primitive-textfield__native-input"/>
          - unexpected value "17.08.2020 – 17.08.2020"


      261 |                 await mobileCalendar.confirmButton.click();
      262 |
    > 263 |                 await expect(inputDateRange.textfield).toHaveValue(
          |                                                        ^
      264 |                     `17.09.2020${CHAR_NO_BREAK_SPACE}–${CHAR_NO_BREAK_SPACE}17.09.2020`,
      265 |                 );
      266 |             });
        at /Users/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests/legacy/input-date-range/input-date-range.pw.spec.ts:263:56
`17.08.2020${CHAR_NO_BREAK_SPACE}–${CHAR_NO_BREAK_SPACE}17.08.2020`,
`17.09.2020${CHAR_NO_BREAK_SPACE}–${CHAR_NO_BREAK_SPACE}17.09.2020`,
);
});
});
Expand Down

0 comments on commit 8615133

Please sign in to comment.