Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-mobile): virtual-scroll flickers during scroll in zoneless mode #10023

Merged
merged 1 commit into from
Dec 23, 2024
Merged

fix(addon-mobile): virtual-scroll flickers during scroll in zoneless mode #10023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/addon-mobile/components/mobile-calendar/mobile-calendar.style.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,11 +177,15 @@
}

.t-month-wrapper {
display: flex;
margin: 0.625rem 0 -0.625rem;
block-size: 22.125rem; // itemSize: 354px;
flex-direction: column;
}

.t-month {
block-size: 2.75rem;
inline-size: 100%;
line-height: 2.75rem;
padding-left: 1rem;
font-size: 0.875rem;
Expand Down
3 changes: 3 additions & 0 deletions projects/addon-mobile/components/mobile-calendar/mobile-calendar.template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@
</div>
<cdk-virtual-scroll-viewport
#monthsScrollRef
itemSize="354"
maxBufferPx="5000"
minBufferPx="0"
class="t-months"
(scrolledIndexChange)="onMonthChange($event)"
>
Expand Down
2 changes: 1 addition & 1 deletion projects/demo-playwright/tests/legacy/input-date-range/input-date-range.pw.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,10 @@

await inputDateRange.textfield.click();

await expect(inputDateRange.textfield).toHaveScreenshot(

Check failure on line 58 in projects/demo-playwright/tests/legacy/input-date-range/input-date-range.pw.spec.ts

View workflow job for this annotation

GitHub Actions / Playwright / macos-latest / 7 of 9

[webkit] › tests/legacy/input-date-range/input-date-range.pw.spec.ts:48:17 › InputDateRange › API › correct filler display for size L 

  3) [webkit] › tests/legacy/input-date-range/input-date-range.pw.spec.ts:48:17 › InputDateRange › API › correct filler display for size L 
    Error: Timed out 5000ms waiting for expect(locator).toHaveScreenshot(expected)

    Locator: locator('#demo-content').locator('tui-input-date-range').getByRole('textbox')
      Timeout 5000ms exceeded.

    Call log:
      - expect.toHaveScreenshot(01-textfield-size-l-empty.png) with timeout 5000ms
        - generating new stable screenshot expectation
      - waiting for locator('#demo-content').locator('tui-input-date-range').getByRole('textbox')
      - Timeout 5000ms exceeded.


      56 |                 await inputDateRange.textfield.click();
      57 |
    > 58 |                 await expect(inputDateRange.textfield).toHaveScreenshot(
         |                                                        ^
      59 |                     `01-textfield-size-${size}-empty.png`,
      60 |                 );
      61 |                 await expect(inputDateRange.calendar).toHaveScreenshot(
        at /Users/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests/legacy/input-date-range/input-date-range.pw.spec.ts:58:56
`01-textfield-size-${size}-empty.png`,
);
await expect(inputDateRange.calendar).toHaveScreenshot(

Check failure on line 61 in projects/demo-playwright/tests/legacy/input-date-range/input-date-range.pw.spec.ts

View workflow job for this annotation

GitHub Actions / Playwright / macos-latest / 7 of 9

[webkit] › tests/legacy/input-date-range/input-date-range.pw.spec.ts:48:17 › InputDateRange › API › correct filler display for size S 

  1) [webkit] › tests/legacy/input-date-range/input-date-range.pw.spec.ts:48:17 › InputDateRange › API › correct filler display for size S 
    Error: Timed out 5000ms waiting for expect(locator).toHaveScreenshot(expected)

    Locator: locator('tui-calendar-range, tui-mobile-calendar')
      Timeout 5000ms exceeded.

    Call log:
      - expect.toHaveScreenshot(01-calendar-size-s-empty.png) with timeout 5000ms
        - generating new stable screenshot expectation
      - waiting for locator('tui-calendar-range, tui-mobile-calendar')
        - locator resolved to <tui-calendar-range class="ng-star-inserted" _nghost-ng-c3948775841="" _ngcontent-ng-c325314227="">…</tui-calendar-range>
      - taking element screenshot
        - disabled all CSS animations
      - waiting for fonts to load...
      - fonts loaded
      - attempting scroll into view action
        - waiting for element to be stable
      - waiting 100ms before taking screenshot
      - waiting for locator('tui-calendar-range, tui-mobile-calendar')
        - locator resolved to <tui-calendar-range class="ng-star-inserted" _nghost-ng-c3948775841="" _ngcontent-ng-c325314227="">…</tui-calendar-range>
      - taking element screenshot
        - disabled all CSS animations
      - waiting for fonts to load...
      - Timeout 5000ms exceeded.


      59 |                     `01-textfield-size-${size}-empty.png`,
      60 |                 );
    > 61 |                 await expect(inputDateRange.calendar).toHaveScreenshot(
         |                                                       ^
      62 |                     `01-calendar-size-${size}-empty.png`,
      63 |                 );
      64 |
        at /Users/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests/legacy/input-date-range/input-date-range.pw.spec.ts:61:55

Check failure on line 61 in projects/demo-playwright/tests/legacy/input-date-range/input-date-range.pw.spec.ts

View workflow job for this annotation

GitHub Actions / Playwright / macos-latest / 7 of 9

[webkit] › tests/legacy/input-date-range/input-date-range.pw.spec.ts:48:17 › InputDateRange › API › correct filler display for size M 

  2) [webkit] › tests/legacy/input-date-range/input-date-range.pw.spec.ts:48:17 › InputDateRange › API › correct filler display for size M 
    Error: Timed out 5000ms waiting for expect(locator).toHaveScreenshot(expected)

    Locator: locator('tui-calendar-range, tui-mobile-calendar')
      Timeout 5000ms exceeded.

    Call log:
      - expect.toHaveScreenshot(01-calendar-size-m-empty.png) with timeout 5000ms
        - generating new stable screenshot expectation
      - waiting for locator('tui-calendar-range, tui-mobile-calendar')
        - locator resolved to <tui-calendar-range class="ng-star-inserted" _nghost-ng-c3948775841="" _ngcontent-ng-c325314227="">…</tui-calendar-range>
      - taking element screenshot
        - disabled all CSS animations
      - waiting for fonts to load...
      - Timeout 5000ms exceeded.


      59 |                     `01-textfield-size-${size}-empty.png`,
      60 |                 );
    > 61 |                 await expect(inputDateRange.calendar).toHaveScreenshot(
         |                                                       ^
      62 |                     `01-calendar-size-${size}-empty.png`,
      63 |                 );
      64 |
        at /Users/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests/legacy/input-date-range/input-date-range.pw.spec.ts:61:55
`01-calendar-size-${size}-empty.png`,
);

Expand Down Expand Up @@ -260,8 +260,8 @@
await calendarSheet?.clickOnDay(17);
await mobileCalendar.confirmButton.click();

await expect(inputDateRange.textfield).toHaveValue(

Check failure on line 263 in projects/demo-playwright/tests/legacy/input-date-range/input-date-range.pw.spec.ts

View workflow job for this annotation

GitHub Actions / Playwright / ubuntu-latest / 7 of 9

[chromium] › tests/legacy/input-date-range/input-date-range.pw.spec.ts:252:17 › InputDateRange › API › Mobile emulation › Selection of only single date produces range with the same start and end 

  4) [chromium] › tests/legacy/input-date-range/input-date-range.pw.spec.ts:252:17 › InputDateRange › API › Mobile emulation › Selection of only single date produces range with the same start and end 
    Error: Timed out 5000ms waiting for expect(locator).toHaveValue(expected)

    Locator: locator('#demo-content').locator('tui-input-date-range').getByRole('textbox')
    Expected string: "17.09.2020 – 17.09.2020"
    Received string: "17.08.2020 – 17.08.2020"
    Call log:
      - expect.toHaveValue with timeout 5000ms
      - waiting for locator('#demo-content').locator('tui-input-date-range').getByRole('textbox')
        9 × locator resolved to <input tabindex="0" inputmode="" placeholder="" aria-invalid="false" _ngcontent-ng-c3831396199="" id="tui_interactive_431601061540000" class="t-input ng-untouched ng-pristine ng-valid" automation-id="tui-primitive-textfield__native-input"/>
          - unexpected value "17.08.2020 – 17.08.2020"


      261 |                 await mobileCalendar.confirmButton.click();
      262 |
    > 263 |                 await expect(inputDateRange.textfield).toHaveValue(
          |                                                        ^
      264 |                     `17.09.2020${CHAR_NO_BREAK_SPACE}–${CHAR_NO_BREAK_SPACE}17.09.2020`,
      265 |                 );
      266 |             });
        at /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests/legacy/input-date-range/input-date-range.pw.spec.ts:263:56

Check failure on line 263 in projects/demo-playwright/tests/legacy/input-date-range/input-date-range.pw.spec.ts

View workflow job for this annotation

GitHub Actions / Playwright / macos-latest / 7 of 9

[webkit] › tests/legacy/input-date-range/input-date-range.pw.spec.ts:252:17 › InputDateRange › API › Mobile emulation › Selection of only single date produces range with the same start and end 

  4) [webkit] › tests/legacy/input-date-range/input-date-range.pw.spec.ts:252:17 › InputDateRange › API › Mobile emulation › Selection of only single date produces range with the same start and end 
    Error: Timed out 5000ms waiting for expect(locator).toHaveValue(expected)

    Locator: locator('#demo-content').locator('tui-input-date-range').getByRole('textbox')
    Expected string: "17.09.2020 – 17.09.2020"
    Received string: "17.08.2020 – 17.08.2020"
    Call log:
      - expect.toHaveValue with timeout 5000ms
      - waiting for locator('#demo-content').locator('tui-input-date-range').getByRole('textbox')
        9 × locator resolved to <input tabindex="0" inputmode="" placeholder="" aria-invalid="false" _ngcontent-ng-c3831396199="" id="tui_interactive_431601061540000" class="t-input ng-untouched ng-pristine ng-valid" automation-id="tui-primitive-textfield__native-input"/>
          - unexpected value "17.08.2020 – 17.08.2020"


      261 |                 await mobileCalendar.confirmButton.click();
      262 |
    > 263 |                 await expect(inputDateRange.textfield).toHaveValue(
          |                                                        ^
      264 |                     `17.09.2020${CHAR_NO_BREAK_SPACE}–${CHAR_NO_BREAK_SPACE}17.09.2020`,
      265 |                 );
      266 |             });
        at /Users/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests/legacy/input-date-range/input-date-range.pw.spec.ts:263:56
`17.08.2020${CHAR_NO_BREAK_SPACE}–${CHAR_NO_BREAK_SPACE}17.08.2020`,
`17.09.2020${CHAR_NO_BREAK_SPACE}–${CHAR_NO_BREAK_SPACE}17.09.2020`,
);
});
});
Expand Down
Loading