refactor: add account nonce as input of run_validate and remove validation output

[ArniStarkware]

This change is 

[ArniStarkware]

• refactor: add account nonce as input of run_validate and remove validation output #822 👈
• refactor: remove most fields from statful validator output #521
• refactor: refactor the stateful tx validator to get executable tx as input #519 : 3 other dependent PRs (#520 , #604 , #789 )
• chore: create executable tx creator for testing #672
• chore: move chain_id create for testing to snapi test utils #666 : 2 other dependent PRs (#694 , #701 )
• chore: move transaction creator test util to starknet api #661
• chore: split the inner tx creator in blockifier test utils #660
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite

[codecov]

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 26.62%. Comparing base (7da2d63) to head (5060ddd).
Report is 10 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/gateway/src/gateway.rs	14.28%	2 Missing and 4 partials ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #822       +/-   ##
===========================================
- Coverage   74.29%   26.62%   -47.67%     
===========================================
  Files         358      114      -244     
  Lines       36288    12067    -24221     
  Branches    36288    12067    -24221     
===========================================
- Hits        26960     3213    -23747     
- Misses       7190     8618     +1428     
+ Partials     2138      236     -1902     

Flag	Coverage Δ
	26.62% <40.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yair-starkware]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)

---

crates/gateway/src/gateway.rs line 169 at r1 (raw file):

    let account_nonce = validator.get_nonce(sender_address).map_err(|e| {
        error!("Failed to get nonce for sender address {}: {}", sender_address, e);
        GatewaySpecError::UnexpectedError { data: "Internal server error.".to_owned() }

I don't think this should be an internal error.
When does getting the nonce fail?

Code quote:

        error!("Failed to get nonce for sender address {}: {}", sender_address, e);
        GatewaySpecError::UnexpectedError { data: "Internal server error.".to_owned() }

[Yael-Starkware]

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @yair-starkware)

---

crates/gateway/src/gateway.rs line 169 at r1 (raw file):

Previously, yair-starkware (Yair) wrote…

I don't think this should be an internal error.
When does getting the nonce fail?

Getting the nonce from the storage fails if the contract address doesn't exist, but in this case, the state reader will return the default value and not an error.
Other failures derive from communication, serde, internal papyrus error, etc, so I think it makes sense to classify it as an internal error.

[ArniStarkware]

crates/gateway/src/gateway.rs line 169 at r1 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

Getting the nonce from the storage fails if the contract address doesn't exist, but in this case, the state reader will return the default value and not an error.
Other failures derive from communication, serde, internal papyrus error, etc, so I think it makes sense to classify it as an internal error.

If I understand @Yael-Starkware correctly, this should indeed be an internal error. No error should be handled differently, and indeed, some internal errors may arise.

[yair-starkware]

Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @ArniStarkware)

[ArniStarkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

[ArniStarkware]

Merge activity

• Sep 22, 3:05 AM EDT: @ArniStarkware started a stack merge that includes this pull request via Graphite.
• Sep 22, 3:07 AM EDT: Graphite rebased this pull request as part of a merge.
• Sep 22, 3:19 AM EDT: @ArniStarkware merged this pull request with Graphite.