Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockifier): move env var from run time to compile time #2453

Closed
wants to merge 1 commit into from

Conversation

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Dec 4, 2024

Artifacts upload workflows:

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.94%. Comparing base (611737c) to head (1b90f8c).

Files with missing lines Patch % Lines
crates/blockifier/src/test_utils/cairo_compile.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           spr/main/301ed4eb    #2453      +/-   ##
=====================================================
- Coverage              77.40%   71.94%   -5.46%     
=====================================================
  Files                    389      101     -288     
  Lines                  41335    13490   -27845     
  Branches               41335    13490   -27845     
=====================================================
- Hits                   31995     9706   -22289     
+ Misses                  7078     3370    -3708     
+ Partials                2262      414    -1848     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@ArniStarkware
Copy link
Contributor

For reference: https://doc.rust-lang.org/std/macro.env.html

@Itay-Tsabary-Starkware
Copy link
Contributor Author

✓ Commit merged in pull request #2454

@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants