chore(starknet_api): rely on env::current_dir() instead of CARGO_MANIFEST_DIR

[Itay-Tsabary-Starkware]

Stack:

• chore(starknet_sierra_compile): define accessible-at-runtime out_dir env var #2455
• chore(starknet_sierra_compile): move env var from run time to compile… #2454
• chore(blockifier): move env var from run time to compile time #2453
• chore(starknet_api): rely on env::current_dir() instead of CARGO_MANIFEST_DIR #2450 ⬅
• chore(starknet_api): revert use get_packaget_dir instead of env var #2449

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

[reviewable-StarkWare]

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.40%. Comparing base (77232c5) to head (611737c).

Additional details and impacted files

@@                  Coverage Diff                  @@
##           spr/main/a48736e7    #2450      +/-   ##
=====================================================
+ Coverage              77.31%   77.40%   +0.08%     
=====================================================
  Files                    389      389              
  Lines                  41335    41335              
  Branches               41335    41335              
=====================================================
+ Hits                   31959    31995      +36     
+ Misses                  7115     7078      -37     
- Partials                2261     2262       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Artifacts upload workflows:

• Started at 2024-12-04T13:18:15Z
• Started at 2024-12-04T13:52:26Z
• Started at 2024-12-04T13:52:26Z

[github-actions]

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.388 ms 34.804 ms 35.309 ms]
change: [+1.7974% +2.9073% +4.4747%] (p = 0.00 < 0.05)
Performance has regressed.
Found 12 outliers among 100 measurements (12.00%)
4 (4.00%) high mild
8 (8.00%) high severe

full_committer_flow performance regressed!
full_committer_flow time: [29.845 ms 29.881 ms 29.918 ms]
change: [+1.0724% +1.4571% +1.7871%] (p = 0.00 < 0.05)
Performance has regressed.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

[ArniStarkware]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

---

Cargo.lock line 3 at r1 (raw file):

# This file is automatically @generated by Cargo.
# It is not intended for manual editing.
version = 4

Wow.
Probably means nothing... but cool.

Code quote:

version = 4

---

crates/starknet_api/src/test_utils.rs line 23 at r1 (raw file):

/// file in the folder "resources".
pub fn path_in_resources<P: AsRef<Path>>(file_path: P) -> PathBuf {
    std::env::current_dir().unwrap().join("resources").join(file_path)

Nice!
It's cool that there is no need for this to be a macro.

Code quote:

std::env::current_dir()

[Itay-Tsabary-Starkware]

✓ Commit merged in pull request #2454