-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(starknet_api): revert use get_packaget_dir instead of env var #2449
Conversation
Artifacts upload workflows: |
Benchmark movements: full_committer_flow performance improved 😺 |
8c84873
to
f6417f0
Compare
Benchmark movements: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2449 +/- ##
===========================================
+ Coverage 40.10% 77.31% +37.21%
===========================================
Files 26 389 +363
Lines 1895 41335 +39440
Branches 1895 41335 +39440
===========================================
+ Hits 760 31959 +31199
- Misses 1100 7115 +6015
- Partials 35 2261 +2226 ☔ View full report in Codecov by Sentry. |
This reverts commit c45f5cc. commit-id:a48736e7
f6417f0
to
77232c5
Compare
Benchmark movements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
✓ Commit merged in pull request #2454 |
This reverts commit c45f5cc.
Stack: