Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_api): revert use get_packaget_dir instead of env var #2449

Closed
wants to merge 1 commit into from

Conversation

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Dec 4, 2024

Copy link

github-actions bot commented Dec 4, 2024

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [33.658 ms 33.691 ms 33.728 ms]
change: [-1.9884% -1.8070% -1.6352%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
1 (1.00%) high mild
3 (3.00%) high severe

full_committer_flow performance improved 😺
full_committer_flow time: [29.421 ms 29.485 ms 29.563 ms]
change: [-2.3383% -2.0353% -1.6970%] (p = 0.00 < 0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe

Copy link

github-actions bot commented Dec 4, 2024

Benchmark movements:
full_committer_flow performance improved 😺
full_committer_flow time: [29.740 ms 29.794 ms 29.848 ms]
change: [-1.5707% -1.3265% -1.0835%] (p = 0.00 < 0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.31%. Comparing base (e3165c4) to head (77232c5).
Report is 708 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2449       +/-   ##
===========================================
+ Coverage   40.10%   77.31%   +37.21%     
===========================================
  Files          26      389      +363     
  Lines        1895    41335    +39440     
  Branches     1895    41335    +39440     
===========================================
+ Hits          760    31959    +31199     
- Misses       1100     7115     +6015     
- Partials       35     2261     +2226     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 4, 2024

Benchmark movements:
full_committer_flow performance improved 😺
full_committer_flow time: [29.372 ms 29.428 ms 29.492 ms]
change: [-1.5229% -1.2979% -1.0499%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
2 (2.00%) high mild
2 (2.00%) high severe

Copy link
Contributor

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware
Copy link
Contributor Author

✓ Commit merged in pull request #2454

@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants