Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blockifier): min compiler version for sierra gas type #2421

Draft
wants to merge 2 commits into
base: graphite-base/2421
Choose a base branch
from

Conversation

AvivYossef-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Dec 3, 2024

@AvivYossef-starkware AvivYossef-starkware marked this pull request as draft December 3, 2024 10:10
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/get_versioned_casm branch 2 times, most recently from 002ea4b to e0a4c01 Compare December 3, 2024 13:31
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_min_compiler_version_for_sierra_gas_type branch from 245624e to e5d5bca Compare December 3, 2024 13:31
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)


crates/blockifier/src/execution/contract_class.rs line 266 at r2 (raw file):

    /// Returns whether this contract should run using Cairo steps or Sierra gas.
    pub fn tracked_resource(&self, min_sierra_version: &SierraVersion) -> TrackedResource {
        if *min_sierra_version <= self.sierra_version {

This field is irrelevant now. You need to move fn tracked_resource to your new object - VersionedRunnableContractClass - it is the only one holding the actual Sierra version

Code quote:

self.sierra_version

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_min_compiler_version_for_sierra_gas_type branch from 4a0764f to 9325c6e Compare December 4, 2024 09:49
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/get_versioned_casm branch 8 times, most recently from 7763b88 to 0999dfe Compare December 10, 2024 07:36
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/get_versioned_casm branch 5 times, most recently from 12d69a6 to 1236dca Compare December 10, 2024 14:43
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/get_versioned_casm branch 4 times, most recently from a066e45 to 31dda01 Compare December 15, 2024 11:43
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/get_versioned_casm branch 3 times, most recently from 422c84e to 925eedd Compare December 15, 2024 15:27
@AvivYossef-starkware AvivYossef-starkware changed the base branch from aviv/get_versioned_casm to graphite-base/2421 December 15, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants