-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(blockifier): min compiler version for sierra gas type #2421
base: graphite-base/2421
Are you sure you want to change the base?
refactor(blockifier): min compiler version for sierra gas type #2421
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)
002ea4b
to
e0a4c01
Compare
245624e
to
e5d5bca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)
e0a4c01
to
865d1dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)
crates/blockifier/src/execution/contract_class.rs
line 266 at r2 (raw file):
/// Returns whether this contract should run using Cairo steps or Sierra gas. pub fn tracked_resource(&self, min_sierra_version: &SierraVersion) -> TrackedResource { if *min_sierra_version <= self.sierra_version {
This field is irrelevant now. You need to move fn tracked_resource
to your new object - VersionedRunnableContractClass - it is the only one holding the actual Sierra version
Code quote:
self.sierra_version
865d1dc
to
2fdc7e4
Compare
e5d5bca
to
1311cf6
Compare
2fdc7e4
to
3f7ecd2
Compare
1311cf6
to
4a0764f
Compare
3f7ecd2
to
f9fb3ea
Compare
f9fb3ea
to
6475cf1
Compare
4a0764f
to
9325c6e
Compare
6475cf1
to
18aa37e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)
18aa37e
to
5fe2ded
Compare
7763b88
to
0999dfe
Compare
12d69a6
to
1236dca
Compare
a066e45
to
31dda01
Compare
422c84e
to
925eedd
Compare
925eedd
to
8a0b219
Compare
No description provided.