-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(blockifier): add get versioned class to feature contract #2678
Open
AvivYossef-starkware
wants to merge
1
commit into
aviv/add_erc20_sierra_contract
Choose a base branch
from
aviv/get_versioned_class_to_feature_contract
base: aviv/add_erc20_sierra_contract
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore(blockifier): add get versioned class to feature contract #2678
AvivYossef-starkware
wants to merge
1
commit into
aviv/add_erc20_sierra_contract
from
aviv/get_versioned_class_to_feature_contract
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 15, 2024
AvivYossef-starkware
requested review from
amosStarkware and
dorimedini-starkware
December 15, 2024 15:30
dorimedini-starkware
approved these changes
Dec 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware)
This was referenced Dec 15, 2024
AvivYossef-starkware
force-pushed
the
aviv/add_erc20_sierra_contract
branch
from
December 15, 2024 19:04
c857512
to
69c3d44
Compare
AvivYossef-starkware
force-pushed
the
aviv/get_versioned_class_to_feature_contract
branch
from
December 15, 2024 19:05
83b7b5a
to
ab56dd1
Compare
AvivYossef-starkware
force-pushed
the
aviv/add_erc20_sierra_contract
branch
from
December 15, 2024 19:35
69c3d44
to
c17bcea
Compare
AvivYossef-starkware
force-pushed
the
aviv/get_versioned_class_to_feature_contract
branch
from
December 15, 2024 19:35
ab56dd1
to
82253b3
Compare
AvivYossef-starkware
force-pushed
the
aviv/add_erc20_sierra_contract
branch
from
December 15, 2024 20:07
c17bcea
to
e83ae75
Compare
AvivYossef-starkware
force-pushed
the
aviv/get_versioned_class_to_feature_contract
branch
from
December 15, 2024 20:08
82253b3
to
53465de
Compare
AvivYossef-starkware
force-pushed
the
aviv/add_erc20_sierra_contract
branch
from
December 15, 2024 20:18
e83ae75
to
f45b6e0
Compare
AvivYossef-starkware
force-pushed
the
aviv/get_versioned_class_to_feature_contract
branch
from
December 15, 2024 20:21
53465de
to
6e1354f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.