-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(blockifier): state reader trait #2641
refactor(blockifier): state reader trait #2641
Conversation
510cea9
to
309b011
Compare
294da4d
to
f714969
Compare
309b011
to
aa87e34
Compare
f714969
to
715c824
Compare
aa87e34
to
0772948
Compare
715c824
to
c9addaf
Compare
0772948
to
f3d769e
Compare
c9addaf
to
afcd1cc
Compare
f3d769e
to
ed6abd1
Compare
afcd1cc
to
d5d55fb
Compare
ed6abd1
to
f270a74
Compare
f270a74
to
a587059
Compare
b6de543
to
a38fb1d
Compare
a587059
to
a6fe3d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 35 files at r1.
Reviewable status: 6 of 35 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)
crates/starknet_gateway/src/rpc_state_reader_test.rs
line 199 at r2 (raw file):
RunnableCompiledClass::from(result), RunnableCompiledClass::V1(expected_result.try_into().unwrap()) );
please change expected_result
to be of type VersionedRunnableCompiledClass
instead
Code quote:
assert_eq!(
RunnableCompiledClass::from(result),
RunnableCompiledClass::V1(expected_result.try_into().unwrap())
);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 6 of 35 files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware)
crates/blockifier/src/concurrency/versioned_state.rs
line 139 at r2 (raw file):
} fn apply_writes(
please do this in a separate PR
Code quote:
fn apply_writes(
a38fb1d
to
df0d546
Compare
a6fe3d7
to
263131f
Compare
df0d546
to
c857512
Compare
No description provided.