Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blockifier): state reader trait #2641

Conversation

AvivYossef-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@AvivYossef-starkware AvivYossef-starkware marked this pull request as ready for review December 10, 2024 14:57
@AvivYossef-starkware AvivYossef-starkware force-pushed the 12-09-redactor_blockifier_state_reader_trait branch from 510cea9 to 309b011 Compare December 10, 2024 14:58
@AvivYossef-starkware AvivYossef-starkware changed the title redactor(blockifier): state reader trait refactor(blockifier): state reader trait Dec 10, 2024
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_py_state_reader branch from 294da4d to f714969 Compare December 12, 2024 17:56
@AvivYossef-starkware AvivYossef-starkware force-pushed the 12-09-redactor_blockifier_state_reader_trait branch from 309b011 to aa87e34 Compare December 12, 2024 17:56
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_py_state_reader branch from f714969 to 715c824 Compare December 15, 2024 07:41
@AvivYossef-starkware AvivYossef-starkware force-pushed the 12-09-redactor_blockifier_state_reader_trait branch from aa87e34 to 0772948 Compare December 15, 2024 07:41
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_py_state_reader branch from 715c824 to c9addaf Compare December 15, 2024 09:13
@AvivYossef-starkware AvivYossef-starkware force-pushed the 12-09-redactor_blockifier_state_reader_trait branch from 0772948 to f3d769e Compare December 15, 2024 09:13
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_py_state_reader branch from c9addaf to afcd1cc Compare December 15, 2024 10:58
@AvivYossef-starkware AvivYossef-starkware force-pushed the 12-09-redactor_blockifier_state_reader_trait branch from f3d769e to ed6abd1 Compare December 15, 2024 10:58
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_py_state_reader branch from afcd1cc to d5d55fb Compare December 15, 2024 11:43
@AvivYossef-starkware AvivYossef-starkware force-pushed the 12-09-redactor_blockifier_state_reader_trait branch from ed6abd1 to f270a74 Compare December 15, 2024 11:43
@AvivYossef-starkware AvivYossef-starkware force-pushed the 12-09-redactor_blockifier_state_reader_trait branch from f270a74 to a587059 Compare December 15, 2024 12:30
@AvivYossef-starkware AvivYossef-starkware changed the base branch from aviv/refactor_py_state_reader to aviv/add_erc20_sierra_contract December 15, 2024 12:30
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_erc20_sierra_contract branch from b6de543 to a38fb1d Compare December 15, 2024 12:34
@AvivYossef-starkware AvivYossef-starkware force-pushed the 12-09-redactor_blockifier_state_reader_trait branch from a587059 to a6fe3d7 Compare December 15, 2024 12:34
Copy link
Collaborator

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 35 files at r1.
Reviewable status: 6 of 35 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)


crates/starknet_gateway/src/rpc_state_reader_test.rs line 199 at r2 (raw file):

        RunnableCompiledClass::from(result),
        RunnableCompiledClass::V1(expected_result.try_into().unwrap())
    );

please change expected_result to be of type VersionedRunnableCompiledClass instead

Code quote:

    assert_eq!(
        RunnableCompiledClass::from(result),
        RunnableCompiledClass::V1(expected_result.try_into().unwrap())
    );

Copy link
Collaborator

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 6 of 35 files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware)


crates/blockifier/src/concurrency/versioned_state.rs line 139 at r2 (raw file):

    }

    fn apply_writes(

please do this in a separate PR

Code quote:

fn apply_writes(

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants