Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- TO DELETE chore(blockifier): add struct ExecutionFlags to AccountTransaction #2354

Conversation

avivg-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/add_struct_execution_flags_to_accounttx branch from bec5223 to afbd6f2 Compare November 28, 2024 15:36
@avivg-starkware avivg-starkware marked this pull request as ready for review November 28, 2024 15:36
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 57.95455% with 37 lines in your changes missing coverage. Please review.

Project coverage is 61.14%. Comparing base (e3165c4) to head (66b781c).
Report is 726 commits behind head on main.

Files with missing lines Patch % Lines
crates/native_blockifier/src/py_transaction.rs 0.00% 19 Missing ⚠️
...ution/src/state_reader/reexecution_state_reader.rs 0.00% 7 Missing ⚠️
crates/papyrus_execution/src/lib.rs 58.82% 6 Missing and 1 partial ⚠️
...lockifier/src/transaction/transaction_execution.rs 63.63% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2354       +/-   ##
===========================================
+ Coverage   40.10%   61.14%   +21.04%     
===========================================
  Files          26      206      +180     
  Lines        1895    22901    +21006     
  Branches     1895    22901    +21006     
===========================================
+ Hits          760    14003    +13243     
- Misses       1100     7903     +6803     
- Partials       35      995      +960     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/explicit_creation_of_account_transaction branch from 02ea900 to c168755 Compare December 1, 2024 12:24
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/add_struct_execution_flags_to_accounttx branch from afbd6f2 to b74677d Compare December 2, 2024 17:14
@avivg-starkware avivg-starkware changed the base branch from avivg/blockifier/explicit_creation_of_account_transaction to avivg/blockifier/invoke_declare_deployaccount_change_ret_type December 2, 2024 17:14
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/invoke_declare_deployaccount_change_ret_type branch from d1f3d9d to 3ee98a3 Compare December 2, 2024 17:17
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/add_struct_execution_flags_to_accounttx branch from b74677d to e1d224f Compare December 2, 2024 17:18
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/invoke_declare_deployaccount_change_ret_type branch 2 times, most recently from 17dc894 to 16eed33 Compare December 3, 2024 10:25
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/add_struct_execution_flags_to_accounttx branch 3 times, most recently from 9e9a71d to 5bf81e9 Compare December 3, 2024 11:26
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/invoke_declare_deployaccount_change_ret_type branch from 16eed33 to c5e3b6f Compare December 3, 2024 12:13
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/add_struct_execution_flags_to_accounttx branch from 5bf81e9 to 23894e7 Compare December 3, 2024 12:13
@avivg-starkware avivg-starkware changed the base branch from avivg/blockifier/invoke_declare_deployaccount_change_ret_type to avivg/blockifier/use_invoke_tx_instead_of_account_invoke_tx December 3, 2024 12:13
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/use_invoke_tx_instead_of_account_invoke_tx branch 2 times, most recently from 15d3b81 to 0e07882 Compare December 3, 2024 12:17
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/add_struct_execution_flags_to_accounttx branch from 23894e7 to 3e3f21e Compare December 3, 2024 12:17
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/use_invoke_tx_instead_of_account_invoke_tx branch from 0e07882 to b076c16 Compare December 3, 2024 12:19
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/use_invoke_tx_instead_of_account_invoke_tx branch from b076c16 to a9f4ae2 Compare December 3, 2024 13:07
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/add_struct_execution_flags_to_accounttx branch from 3e3f21e to 940406b Compare December 3, 2024 13:08
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/use_invoke_tx_instead_of_account_invoke_tx branch from a9f4ae2 to ab0a55d Compare December 3, 2024 13:10
@avivg-starkware avivg-starkware changed the title chore(blockifier): add struct ExecutionFlags to AccountTransaction chore(blockifier): add struct ExecutionFlags to AccountTransaction - TO DELETE Dec 3, 2024
@avivg-starkware avivg-starkware changed the title chore(blockifier): add struct ExecutionFlags to AccountTransaction - TO DELETE - TO DELETE chore(blockifier): add struct ExecutionFlags to AccountTransaction Dec 3, 2024
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/use_invoke_tx_instead_of_account_invoke_tx branch 3 times, most recently from bac51a0 to 0d554b2 Compare December 3, 2024 14:09
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/add_struct_execution_flags_to_accounttx branch from 940406b to 8db0bed Compare December 3, 2024 14:09
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/use_invoke_tx_instead_of_account_invoke_tx branch from bac51a0 to b523e04 Compare December 3, 2024 15:34
@avivg-starkware avivg-starkware changed the base branch from avivg/blockifier/use_invoke_tx_instead_of_account_invoke_tx to graphite-base/2354 December 4, 2024 13:14
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/add_struct_execution_flags_to_accounttx branch from 8db0bed to 59ba790 Compare December 4, 2024 13:15
@avivg-starkware avivg-starkware changed the base branch from graphite-base/2354 to main December 4, 2024 13:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants