Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockifier): access self.execution_flags instead of passing as args #2491

Conversation

avivg-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.96%. Comparing base (e3165c4) to head (4dbb97b).
Report is 733 commits behind head on main.

Files with missing lines Patch % Lines
.../blockifier/src/transaction/account_transaction.rs 94.44% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2491       +/-   ##
===========================================
+ Coverage   40.10%   71.96%   +31.86%     
===========================================
  Files          26       98       +72     
  Lines        1895    13488    +11593     
  Branches     1895    13488    +11593     
===========================================
+ Hits          760     9707     +8947     
- Misses       1100     3366     +2266     
- Partials       35      415      +380     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/rename_fn_account_invoke_tx branch from 6cf2fd9 to abd6993 Compare December 5, 2024 14:31
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/access_execution_flags_instead_of_passing branch from 6baed1b to 5d29d19 Compare December 5, 2024 14:31
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/rename_fn_account_invoke_tx branch from abd6993 to 86eaf8f Compare December 5, 2024 15:46
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/access_execution_flags_instead_of_passing branch from 5d29d19 to a9a23df Compare December 5, 2024 15:46
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/rename_fn_account_invoke_tx branch from 86eaf8f to 4de45ba Compare December 5, 2024 19:51
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/access_execution_flags_instead_of_passing branch from a9a23df to 31d9a8f Compare December 5, 2024 19:51
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/rename_fn_account_invoke_tx branch from 4de45ba to 774db28 Compare December 5, 2024 20:22
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/access_execution_flags_instead_of_passing branch from 31d9a8f to 7bcc01b Compare December 5, 2024 20:23
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/rename_fn_account_invoke_tx branch from 774db28 to 44111ed Compare December 5, 2024 21:23
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/access_execution_flags_instead_of_passing branch from 7bcc01b to ed06457 Compare December 5, 2024 21:24
Copy link
Contributor Author

@avivg-starkware avivg-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/rename_fn_account_invoke_tx branch from 44111ed to af6a734 Compare December 5, 2024 21:56
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/access_execution_flags_instead_of_passing branch from ed06457 to f36903a Compare December 5, 2024 21:57
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/rename_fn_account_invoke_tx branch from af6a734 to dca892f Compare December 6, 2024 08:16
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/access_execution_flags_instead_of_passing branch from f36903a to 1ff8070 Compare December 6, 2024 08:17
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/rename_fn_account_invoke_tx branch from dca892f to d71364e Compare December 6, 2024 09:29
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/access_execution_flags_instead_of_passing branch from 1ff8070 to 867671f Compare December 6, 2024 09:29
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/rename_fn_account_invoke_tx branch from d71364e to 7c11b44 Compare December 6, 2024 09:29
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/access_execution_flags_instead_of_passing branch from 867671f to 3d5616d Compare December 6, 2024 09:30
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/rename_fn_account_invoke_tx branch from 7c11b44 to cab341a Compare December 6, 2024 15:52
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/access_execution_flags_instead_of_passing branch from 3d5616d to e916dcd Compare December 6, 2024 15:52
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/rename_fn_account_invoke_tx branch from cab341a to 45a5f8f Compare December 6, 2024 15:54
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/access_execution_flags_instead_of_passing branch from e916dcd to 6a455cd Compare December 6, 2024 15:54
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/rename_fn_account_invoke_tx branch 2 times, most recently from 99f5d0a to 3524b51 Compare December 6, 2024 17:09
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/access_execution_flags_instead_of_passing branch 2 times, most recently from f69d9e9 to 5acf987 Compare December 6, 2024 17:10
Copy link
Contributor Author

avivg-starkware commented Dec 6, 2024

Merge activity

  • Dec 6, 4:37 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 6, 4:39 PM EST: Graphite rebased this pull request as part of a merge.
  • Dec 6, 4:57 PM EST: A user merged this pull request with Graphite.

@avivg-starkware avivg-starkware changed the base branch from avivg/blockifier/rename_fn_account_invoke_tx to graphite-base/2491 December 6, 2024 21:37
@avivg-starkware avivg-starkware changed the base branch from graphite-base/2491 to main December 6, 2024 21:37
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/access_execution_flags_instead_of_passing branch from 5acf987 to 4dbb97b Compare December 6, 2024 21:38
@avivg-starkware avivg-starkware merged commit 0896088 into main Dec 6, 2024
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2024
@avivg-starkware avivg-starkware deleted the avivg/blockifier/access_execution_flags_instead_of_passing branch December 8, 2024 09:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants