chore(blockifier): enforce_fee() impl by api::executable_transaction::AccountTransaction

[avivg-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[avivg-starkware]

• chore(blockifier): use test_utils::invoke_tx() instead of trans::test_utils::account_invoke_tx() #2428 : 2 dependent PRs (#2354 , #2429 )
• chore(blockifier): invoke() declare() deploy_account() change ret val to api_tx #2412
• chore(blockifier): enforce_fee() impl by api::executable_transaction::AccountTransaction #2377 👈 (View in Graphite)
• chore(blockifier): explicit creation of AccountTransaction #2331
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.42%. Comparing base (e3165c4) to head (0502be4).
Report is 678 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/blockifier/src/transaction/transactions.rs	60.00%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2377       +/-   ##
===========================================
+ Coverage   40.10%   71.42%   +31.32%     
===========================================
  Files          26      102       +76     
  Lines        1895    13625    +11730     
  Branches     1895    13625    +11730     
===========================================
+ Hits          760     9732     +8972     
- Misses       1100     3479     +2379     
- Partials       35      414      +379     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Artifacts upload workflows:

• Started at 2024-12-01T12:50:30Z
• Started at 2024-12-02T17:17:51Z
• Started at 2024-12-03T11:31:16Z
• Started at 2024-12-03T12:15:04Z
• Started at 2024-12-03T12:15:24Z
• Started at 2024-12-03T12:15:24Z
• Started at 2024-12-03T12:15:53Z
• Started at 2024-12-03T12:15:57Z
• Started at 2024-12-03T12:16:54Z
• Started at 2024-12-03T12:18:57Z

[Yoni-Starkware]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)

---

crates/blockifier/src/transaction/transactions.rs line 409 at r1 (raw file):

/// Determines whether the fee should be enforced for the given transaction.
pub fn enforce_fee(tx: &AccountTransaction, only_query: bool) -> bool {
    tx.create_tx_info(only_query).enforce_fee()

Add a TODO to consider doing it without create_tx_info

Code quote:

pub fn enforce_fee(tx: &AccountTransaction, only_query: bool) -> bool {
    tx.create_tx_info(only_query).enforce_fee()

[avivg-starkware]

Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

---

crates/blockifier/src/transaction/transactions.rs line 409 at r1 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Add a TODO to consider doing it without create_tx_info

Done

[avivg-starkware]

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)