Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_batcher): remove sequncer address from block builder config #2425

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@ArniStarkware ArniStarkware requested a review from alonh5 December 3, 2024 11:03
@ArniStarkware ArniStarkware marked this pull request as ready for review December 3, 2024 11:03
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/placeholder_sequnecer_address branch from da661e5 to 90e1f06 Compare December 3, 2024 12:07
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/remove_sequencer_address_from_config branch from 5d04986 to 880ea73 Compare December 3, 2024 12:07
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/placeholder_sequnecer_address branch from 90e1f06 to 998a21e Compare December 3, 2024 12:24
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/remove_sequencer_address_from_config branch from 880ea73 to 2b3c009 Compare December 3, 2024 12:24
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/placeholder_sequnecer_address branch from 998a21e to a8aab7c Compare December 3, 2024 12:54
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/remove_sequencer_address_from_config branch from 2b3c009 to 047413e Compare December 3, 2024 12:55
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/placeholder_sequnecer_address branch from a8aab7c to f86d63a Compare December 3, 2024 14:15
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/remove_sequencer_address_from_config branch from 047413e to 1ba6672 Compare December 3, 2024 14:15
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/placeholder_sequnecer_address branch from f86d63a to 271ec38 Compare December 3, 2024 14:48
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/remove_sequencer_address_from_config branch from 1ba6672 to a474d6e Compare December 3, 2024 14:49
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/placeholder_sequnecer_address branch from 271ec38 to 58e2910 Compare December 3, 2024 16:06
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/remove_sequencer_address_from_config branch from a474d6e to 12e31a8 Compare December 3, 2024 16:07
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/placeholder_sequnecer_address branch from 58e2910 to ab817d4 Compare December 5, 2024 13:42
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/placeholder_sequnecer_address branch from ab817d4 to b1573a9 Compare December 5, 2024 13:44
Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)


crates/sequencing/papyrus_consensus/src/config.rs line 93 at r2 (raw file):

        };
        Self {
            validator_id: ValidatorId::from(1991_u128),

This PR is where I meant you should change it. Rebase the stack and you'll see the conflicts

Suggestion:

100_u32

@ArniStarkware ArniStarkware changed the base branch from arni/batcher/block_builder_factory/placeholder_sequnecer_address to graphite-base/2425 December 5, 2024 14:48
@ArniStarkware
Copy link
Contributor Author

This PR is no longer relevant. It was covered by it's downstack.

@ArniStarkware ArniStarkware deleted the arni/batcher/block_builder_factory/remove_sequencer_address_from_config branch December 5, 2024 14:53
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants