Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockifier): use suggested function to get dir #2203

Closed

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

Artifacts upload triggered. View details here

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.08%. Comparing base (4686fa7) to head (1d44067).

Additional details and impacted files
@@                  Coverage Diff                   @@
##           graphite-base/2203    #2203      +/-   ##
======================================================
- Coverage               77.32%   69.08%   -8.25%     
======================================================
  Files                     386      109     -277     
  Lines                   40386    13885   -26501     
  Branches                40386    13885   -26501     
======================================================
- Hits                    31228     9592   -21636     
+ Misses                   6849     3884    -2965     
+ Partials                 2309      409    -1900     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ArniStarkware ArniStarkware changed the base branch from arni/infra_utils/share_get_absolute_path to graphite-base/2203 November 21, 2024 07:53
Copy link

Artifacts upload triggered. View details here

@ArniStarkware ArniStarkware force-pushed the arni/cargo_menifest_dir/versioned_constants_test branch from 1d44067 to 079ab62 Compare November 21, 2024 08:16
@ArniStarkware ArniStarkware changed the base branch from graphite-base/2203 to main November 21, 2024 08:16
@ArniStarkware ArniStarkware force-pushed the arni/cargo_menifest_dir/versioned_constants_test branch from 079ab62 to b0a39cd Compare November 21, 2024 08:16
Copy link

Artifacts upload triggered. View details here

Copy link

Artifacts upload triggered. View details here

Copy link

Artifacts upload triggered. View details here

@ArniStarkware
Copy link
Contributor Author

A new PR will be opened.

@ArniStarkware ArniStarkware deleted the arni/cargo_menifest_dir/versioned_constants_test branch November 26, 2024 08:28
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants