chore(infra): add error variant for file not found on get path

[ArniStarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[ArniStarkware]

• chore(infra): add error variant for file not found on get path #2169 👈 (View in Graphite)
• chore(infra): share get_absolute_path infra util with snapi test utils #2075 : 1 other dependent PR (#2203 )
• chore(infra): move get_absolute_path function to infra_utils #2074
• feat: create infra utils crate #2073
• chore: share the test util path_in_resources #2052
• chore: share the test util get_absolute_path #2026
• chore: move nonce manager struct near the impl block #2020
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [30.615 ms 30.655 ms 30.698 ms]
change: [+3.6680% +3.9167% +4.1523%] (p = 0.00 < 0.05)
Performance has regressed.
Found 6 outliers among 100 measurements (6.00%)
6 (6.00%) high mild

[codecov]

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.21%. Comparing base (e3165c4) to head (2910d40).
Report is 532 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/infra_utils/src/path.rs	77.77%	1 Missing and 1 partial ⚠️
.../starknet_sequencer_node/src/config/node_config.rs	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2169       +/-   ##
===========================================
+ Coverage   40.10%   77.21%   +37.10%     
===========================================
  Files          26      386      +360     
  Lines        1895    40412    +38517     
  Branches     1895    40412    +38517     
===========================================
+ Hits          760    31203    +30443     
- Misses       1100     6905     +5805     
- Partials       35     2304     +2269     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [33.611 ms 33.803 ms 34.093 ms]
change: [-5.1543% -3.5211% -1.9901%] (p = 0.00 < 0.05)
Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
2 (2.00%) high mild
8 (8.00%) high severe

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)

---

crates/infra_utils/src/path.rs line 27 at r1 (raw file):

        // If `CARGO_MANIFEST_DIR` isn't set, fall back to the current working directory
        .unwrap_or(env::current_dir().expect("Failed to get current directory"));
    let path_buf = base_dir.join(relative_path);

Please remove this suffix.

Code quote:

_buf

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Benchmark movements:
full_committer_flow performance improved 😺
full_committer_flow time: [29.323 ms 29.359 ms 29.397 ms]
change: [-1.9867% -1.7763% -1.5781%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild

[ArniStarkware]

Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)

---

crates/infra_utils/src/path.rs line 27 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please remove this suffix.

Done.

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Benchmark movements:
full_committer_flow performance improved 😺
full_committer_flow time: [29.497 ms 29.549 ms 29.605 ms]
change: [-2.1949% -1.9385% -1.6920%] (p = 0.00 < 0.05)
Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severe

[github-actions]

Artifacts upload triggered. View details here

[Itay-Tsabary-Starkware]

Reviewed 1 of 9 files at r2.
Reviewable status: 1 of 11 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)

---

crates/infra_utils/src/path.rs line 8 at r2 (raw file):

#[derive(Debug, Error)]
pub enum GetPathError {

Maybe PathResolutionError? WDYT?

Code quote:

GetPathError

---

crates/infra_utils/src/path.rs line 15 at r2 (raw file):

    IoError(#[from] std::io::Error),
}

Please add a todo on me (tsabary): wrap path-related env::* invocations in the repo as utility functions here

---

crates/infra_utils/src/path.rs line 40 at r2 (raw file):

    Ok(path)
}

Please add tests for this: one that successfully resolves a path, one that returns PathDoesNotExist, and one that results in IoError.

Code quote:

pub fn resolve_project_relative_path(relative_path: &str) -> Result<PathBuf, GetPathError> {
    let base_dir = path_of_project_root();

    let path = base_dir.join(relative_path);
    if !path.try_exists()? {
        return Err(GetPathError::PathDoesNotExist { path });
    }

    Ok(path)
}

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Benchmark movements:
full_committer_flow performance improved 😺
full_committer_flow time: [29.363 ms 29.409 ms 29.465 ms]
change: [-1.6816% -1.4738% -1.2849%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
3 (3.00%) high mild
2 (2.00%) high severe

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[ArniStarkware]

Reviewable status: 1 of 11 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)

---

crates/infra_utils/src/path.rs line 8 at r2 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Maybe PathResolutionError? WDYT?

Done.

---

crates/infra_utils/src/path.rs line 15 at r2 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please add a todo on me (tsabary): wrap path-related env::* invocations in the repo as utility functions here

Done.

[github-actions]

Benchmark movements:
full_committer_flow performance improved 😺
full_committer_flow time: [29.508 ms 29.566 ms 29.627 ms]
change: [-3.0308% -2.7781% -2.5161%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severe

[Itay-Tsabary-Starkware]

Reviewed 1 of 11 files at r1, 7 of 9 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

---

crates/infra_utils/src/path.rs line 40 at r2 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please add tests for this: one that successfully resolves a path, one that returns PathDoesNotExist, and one that results in IoError.

Will be in a different pr.

[ArniStarkware]

crates/infra_utils/src/path.rs line 40 at r2 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Will be in a different pr.

See: #2210.