Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create infra utils crate #2073

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

Artifacts upload triggered. View details here

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.336 ms 34.380 ms 34.437 ms]
change: [-4.6329% -2.9095% -1.3624%] (p = 0.00 < 0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
3 (3.00%) high mild
5 (5.00%) high severe

@ArniStarkware ArniStarkware force-pushed the arni/test_utils/share_path_in_resources branch from c13d674 to e889dc4 Compare November 17, 2024 06:04
@ArniStarkware ArniStarkware force-pushed the arni/create_infra_utils_crate branch from 89fda5f to 6875169 Compare November 17, 2024 06:04
Copy link

Artifacts upload triggered. View details here

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.38%. Comparing base (e3165c4) to head (0961746).
Report is 510 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2073       +/-   ##
===========================================
+ Coverage   40.10%   77.38%   +37.27%     
===========================================
  Files          26      385      +359     
  Lines        1895    40464    +38569     
  Branches     1895    40464    +38569     
===========================================
+ Hits          760    31313    +30553     
- Misses       1100     6850     +5750     
- Partials       35     2301     +2266     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

Artifacts upload triggered. View details here

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 6 files at r1.
Reviewable status: 3 of 6 files reviewed, 2 unresolved discussions (waiting on @ArniStarkware)


crates/starknet_sequencer_node/src/utils.rs line 26 at r1 (raw file):

    let base_dir = env::var("CARGO_MANIFEST_DIR")
        // Attempt to get the `CARGO_MANIFEST_DIR` environment variable and convert it to `PathBuf`.
        // Ascend two directories ("../..") to get to the project root.

Is this intentionally part of this pr, or a pr-split issue? I don't mind lgtming this though.

Code quote:

// Ascend two directories ("../..") to get to the project root.

crates/infra_utils/Cargo.toml line 7 at r1 (raw file):

repository.workspace = true
license-file.workspace = true
description = "Infrastructure utility functions for the sequencer node."

Not just for the node, could you please remove this part? E.g., papyrus node also needs this.

Code quote:

 for the sequencer node.

@ArniStarkware ArniStarkware changed the base branch from arni/test_utils/share_path_in_resources to graphite-base/2073 November 19, 2024 12:56
@ArniStarkware ArniStarkware force-pushed the arni/create_infra_utils_crate branch from 3778061 to 33e89ec Compare November 19, 2024 12:57
@ArniStarkware ArniStarkware changed the base branch from graphite-base/2073 to main November 19, 2024 12:57
@ArniStarkware ArniStarkware force-pushed the arni/create_infra_utils_crate branch from 33e89ec to 278821c Compare November 19, 2024 12:57
Copy link

Artifacts upload triggered. View details here

Copy link

Artifacts upload triggered. View details here

Copy link

Artifacts upload triggered. View details here

Copy link

Artifacts upload triggered. View details here

Copy link

Artifacts upload triggered. View details here

@ArniStarkware ArniStarkware force-pushed the arni/create_infra_utils_crate branch from 278821c to 18235cb Compare November 19, 2024 13:05
Copy link

Artifacts upload triggered. View details here

Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 6 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)


crates/infra_utils/Cargo.toml line 7 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Not just for the node, could you please remove this part? E.g., papyrus node also needs this.

Done.


crates/starknet_sequencer_node/src/utils.rs line 26 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Is this intentionally part of this pr, or a pr-split issue? I don't mind lgtming this though.

Not intentionally.
Just cosmetics that did not fit anywhere.

@ArniStarkware ArniStarkware force-pushed the arni/create_infra_utils_crate branch from 18235cb to 0961746 Compare November 19, 2024 15:11
Copy link

Artifacts upload triggered. View details here

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 6 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

@ArniStarkware ArniStarkware merged commit b05cfd6 into main Nov 20, 2024
22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
@ArniStarkware ArniStarkware deleted the arni/create_infra_utils_crate branch November 28, 2024 13:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants