Skip to content
This repository has been archived by the owner on Dec 26, 2024. It is now read-only.

chore(network): change the way protobuf types are being imported to improve readability #1233

Closed
wants to merge 3 commits into from

Conversation

nagmo-starkware
Copy link
Contributor

@nagmo-starkware nagmo-starkware commented Oct 2, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @nagmo-starkware)


crates/papyrus_network/src/messages/block.rs line 3 at r1 (raw file):

use super::protobuf;

impl protobuf::BlockHeadersResponse {

Move this to messages/mod.rs and erase this file


crates/papyrus_network/src/messages/messages_test.rs line 7 at r1 (raw file):

use super::{read_message, write_message};
use crate::messages::protobuf;

use super::protobuf

Copy link

github-actions bot commented Nov 5, 2023

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale No activity for quite some time. label Nov 5, 2023
@github-actions github-actions bot closed this Nov 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stale No activity for quite some time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants