Skip to content
This repository has been archived by the owner on Dec 26, 2024. It is now read-only.

Commit

Permalink
fix(network): pr fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
nagmo-starkware committed Oct 2, 2023
1 parent 188f994 commit 11e16fd
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,7 @@ async fn create_and_process_outbound_session() {
let mut behaviour =
Behaviour::<BlockHeadersRequest, BlockHeadersResponse>::new(SUBSTREAM_TIMEOUT);

// TODO(shahak): Change to BlockHeadersRequest::default() when the bug that forbids sending
// default messages is fixed.
let query = BlockHeadersRequest { ..Default::default() };
let query = BlockHeadersRequest::default();
let peer_id = PeerId::random();

let outbound_session_id = behaviour.send_query(query.clone(), peer_id);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,7 @@ async fn process_inbound_session() {
);

let (inbound_stream, mut outbound_stream, _) = get_connected_streams().await;
// TODO(shahak): Change to BlockHeadersRequest::default() when the bug that forbids sending
// default messages is fixed.
let query = BlockHeadersRequest { ..Default::default() };
let query = BlockHeadersRequest::default();
let inbound_session_id = InboundSessionId { value: 1 };

simulate_negotiated_inbound_session_from_swarm(
Expand Down Expand Up @@ -313,7 +311,7 @@ async fn process_outbound_session() {
write_message(data, &mut inbound_stream).await.unwrap();
}

for data in hardcoded_data_vec.clone() {
for data in hardcoded_data_vec {
validate_received_data_event(&mut handler, &data, outbound_session_id).await;
}

Expand Down
2 changes: 1 addition & 1 deletion docs/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ Then, you will need to install
- You'll need Ganache only for the tests of the [papyrus_base_layer](../crates/papyrus_base_layer/) crate.
- [Protoc](https://github.com/protocolbuffers/protobuf/releases/tag/v24.3)
- You'll need Protoc only for compiling the [papyrus_network](../crates/papyrus_network/) crate.
- required version is: 24.3.
- required version is: 24.3.
- the `protoc` execution file should be placed in the `papyrus_network` folder (git is set to automatically ignore it).

### CI
Expand Down

0 comments on commit 11e16fd

Please sign in to comment.