Skip to content
This repository has been archived by the owner on Dec 26, 2024. It is now read-only.

fix(network): nake behaviour generic #1152

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Conversation

nagmo-starkware
Copy link
Contributor

@nagmo-starkware nagmo-starkware commented Sep 10, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Merging #1152 (f9bab11) into p2p (14402de) will decrease coverage by 0.15%.
The diff coverage is 66.15%.

@@            Coverage Diff             @@
##              p2p    #1152      +/-   ##
==========================================
- Coverage   73.52%   73.37%   -0.15%     
==========================================
  Files          79       79              
  Lines        6867     6874       +7     
  Branches     6867     6874       +7     
==========================================
- Hits         5049     5044       -5     
- Misses        967      980      +13     
+ Partials      851      850       -1     
Files Changed Coverage Δ
crates/papyrus_network/src/get_blocks/mod.rs 0.00% <0.00%> (ø)
crates/papyrus_network/src/get_blocks/handler.rs 50.00% <57.14%> (+0.92%) ⬆️
crates/papyrus_network/src/get_blocks/behaviour.rs 68.75% <73.68%> (-3.62%) ⬇️
crates/papyrus_network/src/get_blocks/protocol.rs 89.83% <90.00%> (+0.94%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nagmo-starkware)

@ShahakShama ShahakShama merged commit 9336578 into p2p Sep 10, 2023
@ShahakShama ShahakShama deleted the make_behaviour_generic branch September 10, 2023 13:23
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants