Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to wgpu 0.18, naga 0.14, naga_oil 0.11, egui 0.24.1 #13732

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

torokati44
Copy link
Member

@torokati44 torokati44 commented Oct 26, 2023

Currently blocked by, and mostly based on: emilk/egui#3505
EDIT: This is now merged, waiting for a new release.
EDIT: egui 0.24 is now out.

Also blocked by bevyengine/naga_oil#63, which is in turn, by gfx-rs/wgpu#4569.
EDIT: The latter is now merged, also waiting for a new release.
EDIT: A backport of the latter is in v0.18: gfx-rs/wgpu#4693
EDIT: naga_oil 0.11.0 and wgpu-core 0.18.1 are now out with these fixes.

Feel free to force-push this branch if any of you continue working on this!

@torokati44
Copy link
Member Author

torokati44 commented Nov 23, 2023

Some remaining issues:

  • The Windows CI runner sometimes gets stuck and the job is terminated after a few hours. I don't know which test causes this.
  • The close button (X) of the desktop player window doesn't work - probably sends a different event now, which we are not handling yet.
  • I'm not entirely sure about all those added ..Default::default()s. I think they are fine, but also maybe some fields are still also explicitly set to their defaults, which could be cleaned up.
  • EDIT: And the downgrade of web-sys and js-sys from 0.3.65 to 0.3.64 because of some feature changes.

@torokati44 torokati44 marked this pull request as ready for review November 23, 2023 18:14
@torokati44 torokati44 force-pushed the wgpu-0.18 branch 3 times, most recently from b910df0 to 1a83140 Compare November 23, 2023 19:44
@torokati44 torokati44 changed the title Update to wgpu 0.18 Update to wgpu 0.18, naga 0.14, naga_oil 0.11, egui 0.24 Nov 24, 2023
@Aaron1011
Copy link
Member

The close button issue will be fixed by emilk/egui#3627 (though we can easily work around it on our end if we want)

@torokati44
Copy link
Member Author

Marking as draft for a short time again, see the comments under gfx-rs/wgpu#4778.

@torokati44 torokati44 marked this pull request as draft November 28, 2023 09:45
@torokati44 torokati44 force-pushed the wgpu-0.18 branch 2 times, most recently from e09c870 to 1c724fa Compare November 30, 2023 22:41
@torokati44 torokati44 changed the title Update to wgpu 0.18, naga 0.14, naga_oil 0.11, egui 0.24 Update to wgpu 0.18, naga 0.14, naga_oil 0.11, egui 0.24.1 Nov 30, 2023
@torokati44
Copy link
Member Author

torokati44 commented Nov 30, 2023

I haven't seen the Windows CI runner failure for a while now.

  • EDIT: Shoot, its suckiness is back. At least it got caught in the act!

The close button (X) is fixed.
I'll leave the judgement of the ..Default::default()s to the reviewers. It's at least not worse than it was.
The web-sys situation is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants