Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web-sys to 0.3.65? #4776

Closed
torokati44 opened this issue Nov 26, 2023 · 9 comments
Closed

Update web-sys to 0.3.65? #4776

torokati44 opened this issue Nov 26, 2023 · 9 comments

Comments

@torokati44
Copy link
Contributor

For updating wgpu to 0.18 in Ruffle (ruffle-rs/ruffle#13732), we'd have to downgrade our web-sys dependency from 0.3.65 to 0.3.64 because of the GpuComputePassTimestampWrite -> GpuComputePassTimestampWrites feature rename.

Would it be possible to update wgpu to web-sys 0.3.65 instead, preferably in a new 0.18 patch release?

It's not a particularly important, we don't require the newer web-sys version; but I assume sooner or later both projects will update anyway, so it would be nice to avoid this back-and-forth on our end.

Also, I noticed that your js-sys dependency is already at 0.3.65.

@cwfitzgerald
Copy link
Member

We've already updated on trunk - we'd accept a PR to the v0.18 branch (similar to #4631)

@torokati44
Copy link
Contributor Author

We've already updated on trunk

Huh, on trunk I'm only seeing js-sys as being at 0.3.65, but not web-sys:

wgpu/Cargo.toml

Lines 160 to 165 in 12ee31d

js-sys = "0.3.65"
wasm-bindgen = "0.2.87"
wasm-bindgen-futures = "0.4.38"
wasm-bindgen-test = "0.3"
web-time = "0.2.3"
web-sys = "0.3.64"

@cwfitzgerald
Copy link
Member

Ah, I think it's just that wgpu is now compatible with both versions.

@torokati44
Copy link
Contributor Author

I don't understand how that's possible when web-sys renamed a feature... 🤔

@cwfitzgerald
Copy link
Member

That feature isn't wired up right now, so we likely just removed the feature.

@torokati44 torokati44 mentioned this issue Nov 26, 2023
6 tasks
@torokati44
Copy link
Contributor Author

It's at least still enabled:

"GpuComputePassTimestampWrite",

Is the proper fix for trunk to remove this line then?

@cwfitzgerald
Copy link
Member

Then I guess i have no idea what's going on lol

@torokati44
Copy link
Contributor Author

Both bump PRs merged (on trunk and v0.18). Thank you!
I'd wait with closing this issue until a new v0.18.x release.

@benjamin-sieffert
Copy link

Hey there, would you mind releasing this fix on the 18 series?
19 has some breaking changes, so the update is not trivial.
Meanwhile, 18 and 19 conflict on web-sys due to this issue here, making it very hard to set up a project that selects wgpu version based on feature flags.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants