Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(over window): fix table iter pk prefix to use deduped partition key #19081

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Oct 23, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

When iterating a sub-range on state table, we should've used deduplicated partition key as table pk prefix, but the original partition key was actually used. This PR fixes it.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: Richard Chien <[email protected]>
@github-actions github-actions bot added the type/fix Bug fix label Oct 23, 2024
@stdrc stdrc changed the title fix table iter prefix fix(over window): fix table iter pk prefix Oct 23, 2024
@stdrc stdrc changed the title fix(over window): fix table iter pk prefix fix(over window): fix table iter pk prefix to use deduped partition key Oct 23, 2024
@stdrc stdrc marked this pull request as ready for review October 23, 2024 12:43
@stdrc stdrc added need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged need-cherry-pick-release-2.0 need-cherry-pick-release-2.1 labels Oct 23, 2024
@stdrc stdrc requested a review from wcy-fdu October 23, 2024 12:44
@stdrc stdrc added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit 73a3d97 Oct 24, 2024
48 of 50 checks passed
@stdrc stdrc deleted the rc/fix-over-window-pk-prefix branch October 24, 2024 06:19
github-actions bot pushed a commit that referenced this pull request Oct 24, 2024
github-actions bot pushed a commit that referenced this pull request Oct 24, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 24, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged need-cherry-pick-release-2.0 need-cherry-pick-release-2.1 type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants