-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(over window): fix table iter pk prefix to use deduped partition key #19081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Chien <[email protected]>
9 tasks
9 tasks
9 tasks
stdrc
changed the title
fix table iter prefix
fix(over window): fix table iter pk prefix
Oct 23, 2024
stdrc
changed the title
fix(over window): fix table iter pk prefix
fix(over window): fix table iter pk prefix to use deduped partition key
Oct 23, 2024
stdrc
added
need-cherry-pick-release-1.10
Open a cherry-pick PR to branch release-1.10 after the current PR is merged
need-cherry-pick-release-2.0
need-cherry-pick-release-2.1
labels
Oct 23, 2024
wcy-fdu
approved these changes
Oct 24, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 24, 2024
…ey (#19081) Signed-off-by: Richard Chien <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Oct 24, 2024
…ey (#19081) Signed-off-by: Richard Chien <[email protected]>
This was referenced Oct 24, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 24, 2024
…ey (#19081) (#19101) Signed-off-by: Richard Chien <[email protected]> Co-authored-by: Richard Chien <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 24, 2024
…ey (#19081) (#19102) Signed-off-by: Richard Chien <[email protected]> Co-authored-by: Richard Chien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
need-cherry-pick-release-1.10
Open a cherry-pick PR to branch release-1.10 after the current PR is merged
need-cherry-pick-release-2.0
need-cherry-pick-release-2.1
type/fix
Bug fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
When iterating a sub-range on state table, we should've used deduplicated partition key as table pk prefix, but the original partition key was actually used. This PR fixes it.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.