-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(over window): skip remaining affected rows when rank is not changed #18950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
9 tasks
stdrc
changed the title
skip remaining affected curr keys when rank has no change
perf(over window): skip remaining affected rows when rank is not changed
Oct 16, 2024
stdrc
force-pushed
the
rc/over-window-state-compute-metric
branch
from
October 17, 2024 08:53
9fe13b2
to
746309b
Compare
stdrc
force-pushed
the
rc/over-window-perf-optimization-1
branch
from
October 17, 2024 08:53
50e2520
to
4fa1dce
Compare
8 tasks
stdrc
force-pushed
the
rc/over-window-state-compute-metric
branch
from
October 21, 2024 04:58
746309b
to
d5e5adc
Compare
stdrc
force-pushed
the
rc/over-window-perf-optimization-1
branch
from
October 21, 2024 04:58
4fa1dce
to
9cbf647
Compare
kwannoel
reviewed
Oct 21, 2024
kwannoel
reviewed
Oct 21, 2024
stdrc
force-pushed
the
rc/over-window-state-compute-metric
branch
from
October 21, 2024 05:43
d5e5adc
to
102e482
Compare
stdrc
force-pushed
the
rc/over-window-perf-optimization-1
branch
from
October 21, 2024 05:43
9cbf647
to
b2059c5
Compare
kwannoel
approved these changes
Oct 21, 2024
stdrc
force-pushed
the
rc/over-window-perf-optimization-1
branch
from
October 21, 2024 07:55
b2059c5
to
c0fd7e7
Compare
9 tasks
st1page
approved these changes
Oct 21, 2024
9 tasks
stdrc
force-pushed
the
rc/over-window-perf-optimization-1
branch
from
October 23, 2024 08:04
c0fd7e7
to
f6d2d5a
Compare
stdrc
changed the base branch from
main
to
rc/over-window-opt-pass-through-unchanged
October 23, 2024 08:04
stdrc
force-pushed
the
rc/over-window-opt-pass-through-unchanged
branch
from
October 23, 2024 08:08
0d87ab2
to
0fc881d
Compare
stdrc
force-pushed
the
rc/over-window-perf-optimization-1
branch
2 times, most recently
from
October 23, 2024 08:13
01a5a65
to
e2055c8
Compare
stdrc
force-pushed
the
rc/over-window-perf-optimization-1
branch
from
October 23, 2024 08:26
e2055c8
to
aa685e8
Compare
stdrc
force-pushed
the
rc/over-window-perf-optimization-1
branch
from
October 23, 2024 08:58
aa685e8
to
c993b5f
Compare
stdrc
force-pushed
the
rc/over-window-opt-pass-through-unchanged
branch
from
October 23, 2024 12:41
099e640
to
1eb8388
Compare
9 tasks
stdrc
force-pushed
the
rc/over-window-perf-optimization-1
branch
2 times, most recently
from
October 23, 2024 13:11
42184a0
to
49c3479
Compare
stdrc
force-pushed
the
rc/over-window-opt-pass-through-unchanged
branch
from
October 25, 2024 06:15
48e3886
to
ca48be1
Compare
stdrc
force-pushed
the
rc/over-window-perf-optimization-1
branch
from
October 25, 2024 06:15
49c3479
to
cdc8c0c
Compare
stdrc
force-pushed
the
rc/over-window-opt-pass-through-unchanged
branch
from
October 28, 2024 09:45
ca48be1
to
13778ee
Compare
stdrc
force-pushed
the
rc/over-window-perf-optimization-1
branch
from
October 28, 2024 09:45
6b7bf3f
to
c16155a
Compare
Base automatically changed from
rc/over-window-opt-pass-through-unchanged
to
main
October 28, 2024 10:57
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
stdrc
force-pushed
the
rc/over-window-perf-optimization-1
branch
from
October 28, 2024 17:06
c16155a
to
44fd039
Compare
stdrc
added a commit
that referenced
this pull request
Nov 4, 2024
…ged (#18950) Signed-off-by: Richard Chien <[email protected]>
stdrc
added a commit
that referenced
this pull request
Nov 8, 2024
…ged (#18950) Signed-off-by: Richard Chien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
For example:
rank() over ( partition by ... order by val )
Rows:
When changing
val
of row101
, it will potenrially affect row102
and103
. Previously, no matter what theval
is changed to, we will re-compute all outputs from row101
to the end of the partition (row103
). After this PR, if the output of row102
is not changed, we will stop the re-computation.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.