Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(over window): avoid recompute information about window frames #19036

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Oct 21, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Avoid recompute frame informations when handling every chunk.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@stdrc stdrc changed the title avoid recompute information about window frames perf(over window): avoid recompute information about window frames Oct 21, 2024
@stdrc stdrc marked this pull request as ready for review October 21, 2024 07:56
@stdrc stdrc requested review from st1page and kwannoel October 21, 2024 07:57
@stdrc stdrc force-pushed the rc/over-window-opt-common-info branch from 5f48086 to 988e6d9 Compare October 23, 2024 08:04
@stdrc stdrc changed the base branch from rc/over-window-perf-optimization-1 to main October 23, 2024 08:04
@stdrc stdrc force-pushed the rc/over-window-opt-common-info branch 2 times, most recently from 41bdd90 to 0bd0784 Compare October 23, 2024 12:41
@stdrc stdrc changed the base branch from main to rc/fix-over-window-pk-prefix October 23, 2024 12:41
Base automatically changed from rc/fix-over-window-pk-prefix to main October 24, 2024 06:19
stdrc added 2 commits October 25, 2024 14:14
Signed-off-by: Richard Chien <[email protected]>
@stdrc stdrc force-pushed the rc/over-window-opt-common-info branch from 0bd0784 to 8495823 Compare October 25, 2024 06:15
@stdrc stdrc added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit 16107fd Oct 28, 2024
30 of 31 checks passed
@stdrc stdrc deleted the rc/over-window-opt-common-info branch October 28, 2024 09:40
stdrc added a commit that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants