refactor(storage): add SST sanity check during commit epoch #18757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwang28
commented
Sep 29, 2024
| @@ -543,7 +543,7 @@ message VacuumTask { | |||
|
|
|||
| // Scan object store to get candidate orphan SSTs. | |||
| message FullScanTask { | |||
| uint64 sst_retention_time_sec = 1; | |||
| uint64 sst_retention_watermark = 1; | |||
There was a problem hiding this comment.
The watermark is meta node's now - SST retention sec.
Previously it's calculated in compute node, which relies on compute node's local clock.
There was a problem hiding this comment.
Just a note: the reason why this change is compatible is because the previous sst_retention_time_sec must be way smaller than sst_retention_watermark. That means:
- If meta is upgraded before compactor, compactor will be less aggressive to delete objects because
now - sst_retention_watermark(using old logic to interpret the new field) is way smaller. - If compactor is upgraded before meta, compactor will also be less aggressive to delete objects because
sst_retention_time_sec(using new logic to interpret the old field) is way smaller
zwang28
commented
Sep 29, 2024
| @@ -32,13 +32,14 @@ message BarrierCompleteResponse { | |||
| string request_id = 1; | |||
| common.Status status = 2; | |||
| repeated CreateMviewProgress create_mview_progress = 3; | |||
| message GroupedSstableInfo { | |||
| message LocalSstableInfo { | |||
There was a problem hiding this comment.
Since SSTs to commit are no longer grouped, I make the pb type name consistent with the corresponding type in mem.
hzxa21
approved these changes
Sep 30, 2024
| @@ -543,7 +543,7 @@ message VacuumTask { | |||
|
|
|||
| // Scan object store to get candidate orphan SSTs. | |||
| message FullScanTask { | |||
| uint64 sst_retention_time_sec = 1; | |||
| uint64 sst_retention_watermark = 1; | |||
There was a problem hiding this comment.
Just a note: the reason why this change is compatible is because the previous sst_retention_time_sec must be way smaller than sst_retention_watermark. That means:
- If meta is upgraded before compactor, compactor will be less aggressive to delete objects because
now - sst_retention_watermark(using old logic to interpret the new field) is way smaller. - If compactor is upgraded before meta, compactor will also be less aggressive to delete objects because
sst_retention_time_sec(using new logic to interpret the old field) is way smaller
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Sep 30, 2024
Merged
This was referenced Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
SstObjectIdTrackerhas been used to prevent full GC from deleteing SSTs that has been written to object store but not committed to meta node.In the context of partial checkpoint, the
SstObjectIdTrackerno longer behave correctly in compute node.So #18641 has removed its usage in compute node.
This PR adds additional SST sanity check during commit epoch, to ensure potentially GCed SSTs won't be committed to Hummock Version.
There's a trade-off between the accuracy and IOPS, pls refer to the new comment in
builder.rs.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.