Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meta): fix test #18783

Merged
merged 3 commits into from
Oct 2, 2024
Merged

fix(meta): fix test #18783

merged 3 commits into from
Oct 2, 2024

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Oct 1, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

The test fails because an additional sanity check has been added in #18757.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@zwang28 zwang28 enabled auto-merge October 1, 2024 15:23
@zwang28 zwang28 disabled auto-merge October 1, 2024 15:47
@zwang28 zwang28 enabled auto-merge October 1, 2024 15:58
@zwang28 zwang28 requested a review from xiangjinwu October 2, 2024 05:43
@zwang28 zwang28 added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit 66890db Oct 2, 2024
33 of 34 checks passed
@zwang28 zwang28 deleted the wangzheng/fix_test branch October 2, 2024 06:11
@kwannoel
Copy link
Contributor

kwannoel commented Oct 2, 2024

lgtm, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants