fix(meta): use object store's timestamp in SST retention sanity check #18930
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
In #18757 and #18779 the sanity check for newly added SSTs are introduced for commit_epoch and report_compaction.
As explained here, the issue is great clock drift may still trick the sanity check and cause correctness issue.
After second thoughts, I believe the additional read I/O overhead is a necessary trade-off to ensure correctness. This PR fixes the sanity check by using object timestamp from object store, ensuring consistency with the approach used during full GC.
The local object timestamp from compute node or compactor will be removed after this PR.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.