fix(meta): fix query rename visitor for complex func calls

[stdrc]

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

We didn't iterate over all components of a function call before this PR when doing relation-renaming.

Checklist

• I have written necessary rustdoc comments
• I have added necessary unit tests and integration tests
• I have added test labels as necessary. See details.
• I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
• My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
• All checks passed in ./risedev check (or alias, ./risedev c)
• My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

• My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

• My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

[stdrc]

• feat(parser): parse IGNORE NULLS in (window) function calls #18028
• refactor(parser): introduce ast::FunctionArgList to contain all info in () of function call #18029
• fix(meta): fix query rename visitor for complex func calls #18023 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stdrc and the rest of your teammates on Graphite

[BugenZhao]

Reminds me of #13477

[stdrc]

Reminds me of #13477

Yes, I also recalled this. Our current visitor pattern is super error-prone.

[yezizp2012]

Good catch! LGTM!