Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(parser): introduce ast::FunctionArgList to contain all info in () of function call #18029

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Aug 13, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

A new FunctionArgList ast struct is introduced to contain all informations inside () of a function call, so that things can be clearer:

pub struct FunctionArgList {
    /// Aggregate function calls may have a `DISTINCT`, e.g. `count(DISTINCT x)`.
    pub distinct: bool,
    pub args: Vec<FunctionArg>,
    /// Whether the last argument is variadic, e.g. `foo(a, b, VARIADIC c)`.
    pub variadic: bool,
    /// Aggregate function calls may have an `ORDER BY`, e.g. `array_agg(x ORDER BY y)`.
    pub order_by: Vec<OrderByExpr>,
}

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

stdrc commented Aug 13, 2024

@stdrc stdrc changed the title introduce ast::FunctionArgList to contain all info in () of function call refactor(parser): introduce ast::FunctionArgList to contain all info in () of function call Aug 13, 2024
@stdrc stdrc marked this pull request as ready for review August 13, 2024 11:42
@stdrc stdrc requested a review from st1page August 13, 2024 11:43
Base automatically changed from rc/fix-query-rename-visitor to main August 14, 2024 05:26
stdrc added 3 commits August 14, 2024 13:30
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
@stdrc stdrc force-pushed the rc/function-arg-list branch from cf24c75 to 02c7f8c Compare August 14, 2024 05:33
@stdrc stdrc enabled auto-merge August 14, 2024 05:37
@stdrc stdrc added this pull request to the merge queue Aug 14, 2024
Merged via the queue into main with commit bd664bb Aug 14, 2024
31 of 32 checks passed
@stdrc stdrc deleted the rc/function-arg-list branch August 14, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants