fix(meta): fix query rename visitor for complex func calls

src/meta/src/controller/rename.rs

@@ -195,7 +195,7 @@ impl QueryRewriter<'_> {
             TableFactor::Derived { subquery, .. } => self.visit_query(subquery),
             TableFactor::TableFunction { args, .. } => {
                 for arg in args {
-                    self.visit_function_args(arg);
+                    self.visit_function_arg(arg);
                 }
             }
             TableFactor::NestedJoin(table_with_joins) => {
@@ -247,8 +247,8 @@ impl QueryRewriter<'_> {
     }
 
     /// Visit function arguments and update all references.
-    fn visit_function_args(&self, function_args: &mut FunctionArg) {
-        match function_args {
+    fn visit_function_arg(&self, function_arg: &mut FunctionArg) {
+        match function_arg {
             FunctionArg::Unnamed(arg) | FunctionArg::Named { arg, .. } => match arg {
                 FunctionArgExpr::Expr(expr) | FunctionArgExpr::ExprQualifiedWildcard(expr, _) => {
                     self.visit_expr(expr)
@@ -267,7 +267,18 @@ impl QueryRewriter<'_> {
     /// Visit function and update all references.
     fn visit_function(&self, function: &mut Function) {
         for arg in &mut function.args {
-            self.visit_function_args(arg);
+            self.visit_function_arg(arg);
+        }
+        for expr in &mut function.order_by {
+            self.visit_expr(&mut expr.expr)
+        }
+        if let Some(over) = &mut function.over {
+            for expr in &mut over.partition_by {
+                self.visit_expr(expr);
+            }
+            for expr in &mut over.order_by {
+                self.visit_expr(&mut expr.expr);
+            }
         }
     }
 
@@ -482,4 +493,28 @@ mod tests {
         let actual = alter_relation_rename_refs(definition, from, to);
         assert_eq!(expected, actual);
     }
+
+    #[test]
+    fn test_rename_with_complex_funcs() {
+        let definition = "CREATE MATERIALIZED VIEW mv1 AS SELECT \
+                            agg1(\
+                              foo.v1, func2(foo.v2) \
+                              ORDER BY \
+                              (SELECT foo.v3 FROM foo), \
+                              (SELECT first_value(foo.v4) OVER (PARTITION BY (SELECT foo.v5 FROM foo) ORDER BY (SELECT foo.v6 FROM foo)) FROM foo)\
+                            ) \
+                          FROM foo";
+        let from = "foo";
+        let to = "bar";
+        let expected = "CREATE MATERIALIZED VIEW mv1 AS SELECT \
+                          agg1(\
+                            foo.v1, func2(foo.v2) \
+                            ORDER BY \
+                            (SELECT foo.v3 FROM bar AS foo), \
+                            (SELECT first_value(foo.v4) OVER (PARTITION BY (SELECT foo.v5 FROM bar AS foo) ORDER BY (SELECT foo.v6 FROM bar AS foo)) FROM bar AS foo)\
+                          ) \
+                        FROM bar AS foo";
+        let actual = alter_relation_rename_refs(definition, from, to);
+        assert_eq!(expected, actual);
+    }
 }