refactor(common): generalize LookupEntryState to EstimatedHashSet
#15843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
This was referenced Mar 21, 2024
stdrc
changed the title
LookupEntryState to EstimatedHashSetLookupEntryState to EstimatedHashSet
stdrc
force-pushed
the
rc/estimated-hash-set
branch
from
749e1e5 to
e21e7e1
Compare
stdrc
force-pushed
the
rc/estimated-hash-set
branch
from
e21e7e1 to
492b386
Compare
stdrc
force-pushed
the
rc/estimated-hash-set
branch
from
492b386 to
6554fa9
Compare
Signed-off-by: Richard Chien <[email protected]>
stdrc
force-pushed
the
rc/estimated-hash-set
branch
from
6554fa9 to
439649d
Compare
BugenZhao
approved these changes
Mar 22, 2024
| #[derive(Default)] | ||
| pub struct EstimatedHashSet<T: EstimateSize> { | ||
| inner: HashSet<T>, | ||
| kv_heap_size: KvSize, |
There was a problem hiding this comment.
cc @yuhao-su May I ask what "kv" in the name is for? 😄
There was a problem hiding this comment.
Just renamed the kv_heap_size field to heap_size. Maybe we should revisit the name of KvSize struct in the future, but let's keep it unchanged in this PR.
| match op { | ||
| Op::Insert | Op::UpdateInsert => { | ||
| values.insert(row.into_owned_row()); | ||
| if !values.insert(row) { | ||
| panic!("inserting a duplicated value"); |
There was a problem hiding this comment.
It appears that we can now safely replace panic with inconsistency_panic after the refactoring.
Signed-off-by: Richard Chien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Seems previously
LookupEntryStateis just a simpleEstimateSizewrapper forHashSet, this PR generalize it toEstimatedHashSetso that other modules can reuse it in the future.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.