Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(common): extract risingwave_common::estimate_size into standalone crate #15841

Merged
merged 6 commits into from
Mar 21, 2024

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Mar 21, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

To improve maintainability and maybe compile speed. No business logic is changed in this PR.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@stdrc stdrc changed the title move MemMonitoredHeap to risingwave_common::memory refactor(common): extract risingwave_common::estimate_size into standalone crate Mar 21, 2024
@stdrc stdrc marked this pull request as ready for review March 21, 2024 09:14
@stdrc stdrc requested a review from a team as a code owner March 21, 2024 09:14
@stdrc stdrc requested review from yuhao-su, xxchan and BugenZhao March 21, 2024 09:14
Base automatically changed from rc/rpc-client-lru-version to main March 21, 2024 14:07
@stdrc stdrc force-pushed the rc/estimate-size branch from 44a420d to a25bc40 Compare March 21, 2024 14:08
@stdrc stdrc enabled auto-merge March 21, 2024 14:09
@stdrc stdrc added this pull request to the merge queue Mar 21, 2024
Merged via the queue into main with commit 75ebd1e Mar 21, 2024
28 of 29 checks passed
@stdrc stdrc deleted the rc/estimate-size branch March 21, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants