feat(optimizer): support strong util #15373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzhseh
reviewed
Feb 29, 2024
| /// `p1 OR p2` is strong if p1 and p2 are strong | ||
| /// | ||
| /// `c1 = 1 OR c2 IS NULL` is strong in `[c1]` (definitely null if c1 is null) | ||
|
|
| /// | ||
| /// `p1 OR p2` is strong if p1 and p2 are strong | ||
| /// | ||
| /// `c1 = 1 OR c2 IS NULL` is strong in `[c1]` (definitely null if c1 is null) |
There was a problem hiding this comment.
What if c2 IS NULL evaluates to True during runtime, according to the logic matrix (where AND and OR are commutative), shouldn't this eventually evalute to True?
There was a problem hiding this comment.
Good catch! I think you are right, this case can't be strong in c1.
9 tasks
xzhseh
approved these changes
Mar 1, 2024
Co-authored-by: Zihao Xu <[email protected]>
BugenZhao
reviewed
Mar 1, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
xiangjinwu
approved these changes
Mar 1, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.