-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(optimizer): support strong util #15373
Merged
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1debd00
support strong util
chenzl25 200e212
fix
chenzl25 a870497
fmt
chenzl25 ed54a0a
fix
chenzl25 cec562a
Update src/frontend/src/optimizer/plan_expr_visitor/strong.rs
chenzl25 d17c4ed
fmt
chenzl25 0a93821
expand _
chenzl25 5c53bcf
Merge branch 'main' into dylan/support_strong_util
chenzl25 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,339 @@ | ||
// Copyright 2024 RisingWave Labs | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
use fixedbitset::FixedBitSet; | ||
|
||
use crate::expr::{ExprImpl, ExprType, FunctionCall, InputRef}; | ||
|
||
/// This utilities are with the same definition in calcite. | ||
/// Utilities for strong predicates. | ||
/// A predicate is strong (or null-rejecting) with regards to selected subset of inputs | ||
/// if it is UNKNOWN if all inputs in selected subset are UNKNOWN. | ||
/// By the way, UNKNOWN is just the boolean form of NULL. | ||
/// | ||
/// Examples: | ||
/// | ||
/// UNKNOWN is strong in `[]` (definitely null) | ||
/// | ||
/// `c = 1` is strong in `[c]` (definitely null if and only if c is null) | ||
/// | ||
/// `c IS NULL` is not strong (always returns TRUE or FALSE, nevernull) | ||
/// | ||
/// `p1 AND p2` is strong in `[p1, p2]` (definitely null if either p1 is null or p2 is null) | ||
/// | ||
/// `p1 OR p2` is strong if p1 and p2 are strong | ||
|
||
#[derive(Default)] | ||
pub struct Strong { | ||
null_columns: FixedBitSet, | ||
} | ||
|
||
impl Strong { | ||
fn new(null_columns: FixedBitSet) -> Self { | ||
Self { null_columns } | ||
} | ||
|
||
/// Returns whether the analyzed expression will definitely return null if | ||
/// all of a given set of input columns are null. | ||
#[allow(dead_code)] | ||
pub fn is_null(expr: &ExprImpl, null_columns: FixedBitSet) -> bool { | ||
let strong = Strong::new(null_columns); | ||
strong.is_null_visit(expr) | ||
} | ||
|
||
fn is_input_ref_null(&self, input_ref: &InputRef) -> bool { | ||
self.null_columns.contains(input_ref.index()) | ||
} | ||
|
||
fn is_null_visit(&self, expr: &ExprImpl) -> bool { | ||
match expr { | ||
ExprImpl::InputRef(input_ref) => self.is_input_ref_null(input_ref), | ||
ExprImpl::Literal(literal) => literal.get_data().is_none(), | ||
ExprImpl::FunctionCall(func_call) => self.is_null_function_call(func_call), | ||
ExprImpl::FunctionCallWithLambda(_) => false, | ||
ExprImpl::AggCall(_) => false, | ||
ExprImpl::Subquery(_) => false, | ||
ExprImpl::CorrelatedInputRef(_) => false, | ||
ExprImpl::TableFunction(_) => false, | ||
ExprImpl::WindowFunction(_) => false, | ||
ExprImpl::UserDefinedFunction(_) => false, | ||
ExprImpl::Parameter(_) => false, | ||
ExprImpl::Now(_) => false, | ||
} | ||
} | ||
|
||
fn is_null_function_call(&self, func_call: &FunctionCall) -> bool { | ||
match func_call.func_type() { | ||
// NOT NULL: This kind of expression is never null. No need to look at its arguments, if it has any. | ||
ExprType::IsNull | ||
| ExprType::IsNotNull | ||
| ExprType::IsDistinctFrom | ||
| ExprType::IsNotDistinctFrom | ||
| ExprType::IsTrue | ||
| ExprType::IsNotTrue | ||
| ExprType::IsFalse | ||
| ExprType::IsNotFalse => false, | ||
// ANY: This kind of expression is null if and only if at least one of its arguments is null. | ||
ExprType::Not | ||
| ExprType::Equal | ||
| ExprType::NotEqual | ||
| ExprType::LessThan | ||
| ExprType::LessThanOrEqual | ||
| ExprType::GreaterThan | ||
| ExprType::GreaterThanOrEqual | ||
| ExprType::Like | ||
| ExprType::Add | ||
| ExprType::AddWithTimeZone | ||
| ExprType::Subtract | ||
| ExprType::Multiply | ||
| ExprType::Modulus | ||
| ExprType::Divide | ||
| ExprType::Cast | ||
| ExprType::Trim | ||
| ExprType::Ltrim | ||
| ExprType::Rtrim | ||
| ExprType::Ceil | ||
| ExprType::Floor | ||
| ExprType::Extract | ||
| ExprType::Greatest | ||
| ExprType::Least => self.any_null(func_call), | ||
ExprType::And | ExprType::Or | ExprType::Coalesce => self.all_null(func_call), | ||
xzhseh marked this conversation as resolved.
Show resolved
Hide resolved
chenzl25 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
// TODO: Function like case when is important but current its structure is complicated, so we need to implement it later if necessary. | ||
// Assume that any other expressions cannot be simplified. | ||
_ => false, | ||
xzhseh marked this conversation as resolved.
Show resolved
Hide resolved
chenzl25 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
} | ||
|
||
fn any_null(&self, func_call: &FunctionCall) -> bool { | ||
func_call | ||
.inputs() | ||
.iter() | ||
.any(|expr| self.is_null_visit(expr)) | ||
} | ||
|
||
fn all_null(&self, func_call: &FunctionCall) -> bool { | ||
func_call | ||
.inputs() | ||
.iter() | ||
.all(|expr| self.is_null_visit(expr)) | ||
} | ||
} | ||
|
||
#[cfg(test)] | ||
mod tests { | ||
xzhseh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
use risingwave_common::types::DataType; | ||
|
||
use super::*; | ||
use crate::expr::ExprImpl::Literal; | ||
|
||
#[test] | ||
fn test_literal() { | ||
let null_columns = FixedBitSet::with_capacity(1); | ||
let expr = Literal(crate::expr::Literal::new(None, DataType::Varchar).into()); | ||
assert!(Strong::is_null(&expr, null_columns.clone())); | ||
|
||
let expr = Literal( | ||
crate::expr::Literal::new(Some("test".to_string().into()), DataType::Varchar).into(), | ||
); | ||
assert!(!Strong::is_null(&expr, null_columns)); | ||
} | ||
|
||
#[test] | ||
fn test_input_ref1() { | ||
let null_columns = FixedBitSet::with_capacity(2); | ||
let expr = InputRef::new(0, DataType::Varchar).into(); | ||
assert!(!Strong::is_null(&expr, null_columns.clone())); | ||
|
||
let expr = InputRef::new(1, DataType::Varchar).into(); | ||
assert!(!Strong::is_null(&expr, null_columns)); | ||
} | ||
|
||
#[test] | ||
fn test_input_ref2() { | ||
let mut null_columns = FixedBitSet::with_capacity(2); | ||
null_columns.insert(0); | ||
null_columns.insert(1); | ||
let expr = InputRef::new(0, DataType::Varchar).into(); | ||
assert!(Strong::is_null(&expr, null_columns.clone())); | ||
|
||
let expr = InputRef::new(1, DataType::Varchar).into(); | ||
assert!(Strong::is_null(&expr, null_columns)); | ||
} | ||
|
||
#[test] | ||
fn test_c1_equal_1_or_c2_is_null() { | ||
let mut null_columns = FixedBitSet::with_capacity(2); | ||
null_columns.insert(0); | ||
let expr = FunctionCall::new_unchecked( | ||
ExprType::Or, | ||
vec![ | ||
FunctionCall::new_unchecked( | ||
ExprType::Equal, | ||
vec![ | ||
InputRef::new(0, DataType::Int64).into(), | ||
Literal( | ||
crate::expr::Literal::new( | ||
Some(1.into()), | ||
DataType::Int32, | ||
) | ||
.into(), | ||
), | ||
], | ||
DataType::Boolean, | ||
) | ||
.into(), | ||
FunctionCall::new_unchecked( | ||
ExprType::IsNull, | ||
vec![InputRef::new(1, DataType::Int64).into()], | ||
DataType::Boolean, | ||
) | ||
.into(), | ||
], | ||
DataType::Boolean, | ||
) | ||
.into(); | ||
assert!(!Strong::is_null(&expr, null_columns)); | ||
} | ||
|
||
#[test] | ||
fn test_divide() { | ||
let mut null_columns = FixedBitSet::with_capacity(2); | ||
null_columns.insert(0); | ||
null_columns.insert(1); | ||
let expr = FunctionCall::new_unchecked( | ||
ExprType::Divide, | ||
vec![ | ||
InputRef::new(0, DataType::Decimal).into(), | ||
InputRef::new(1, DataType::Decimal).into(), | ||
], | ||
DataType::Varchar, | ||
) | ||
.into(); | ||
assert!(Strong::is_null(&expr, null_columns)); | ||
} | ||
|
||
/// generate a test case for (0.8 * sum / count) where sum is null and count is not null | ||
#[test] | ||
fn test_multiply_divide() { | ||
let mut null_columns = FixedBitSet::with_capacity(2); | ||
null_columns.insert(0); | ||
let expr = FunctionCall::new_unchecked( | ||
ExprType::Multiply, | ||
vec![ | ||
Literal(crate::expr::Literal::new(Some(0.8f64.into()), DataType::Float64).into()), | ||
FunctionCall::new_unchecked( | ||
ExprType::Divide, | ||
vec![ | ||
InputRef::new(0, DataType::Decimal).into(), | ||
InputRef::new(1, DataType::Decimal).into(), | ||
], | ||
DataType::Decimal, | ||
) | ||
.into(), | ||
], | ||
DataType::Decimal, | ||
) | ||
.into(); | ||
assert!(Strong::is_null(&expr, null_columns)); | ||
} | ||
|
||
/// generate test cases for is not null | ||
macro_rules! gen_test { | ||
($func:ident, $expr:expr, $expected:expr) => { | ||
#[test] | ||
fn $func() { | ||
let null_columns = FixedBitSet::with_capacity(2); | ||
let expr = $expr; | ||
assert_eq!(Strong::is_null(&expr, null_columns), $expected); | ||
} | ||
}; | ||
} | ||
|
||
gen_test!( | ||
test_is_not_null, | ||
FunctionCall::new_unchecked( | ||
ExprType::IsNotNull, | ||
vec![InputRef::new(0, DataType::Varchar).into()], | ||
DataType::Varchar | ||
) | ||
.into(), | ||
false | ||
); | ||
gen_test!( | ||
test_is_null, | ||
FunctionCall::new_unchecked( | ||
ExprType::IsNull, | ||
vec![InputRef::new(0, DataType::Varchar).into()], | ||
DataType::Varchar | ||
) | ||
.into(), | ||
false | ||
); | ||
gen_test!( | ||
test_is_distinct_from, | ||
FunctionCall::new_unchecked( | ||
ExprType::IsDistinctFrom, | ||
vec![ | ||
InputRef::new(0, DataType::Varchar).into(), | ||
InputRef::new(1, DataType::Varchar).into() | ||
], | ||
DataType::Varchar | ||
) | ||
.into(), | ||
false | ||
); | ||
gen_test!( | ||
test_is_not_distinct_from, | ||
FunctionCall::new_unchecked( | ||
ExprType::IsNotDistinctFrom, | ||
vec![ | ||
InputRef::new(0, DataType::Varchar).into(), | ||
InputRef::new(1, DataType::Varchar).into() | ||
], | ||
DataType::Varchar | ||
) | ||
.into(), | ||
false | ||
); | ||
gen_test!( | ||
test_is_true, | ||
FunctionCall::new_unchecked( | ||
ExprType::IsTrue, | ||
vec![InputRef::new(0, DataType::Varchar).into()], | ||
DataType::Varchar | ||
) | ||
.into(), | ||
false | ||
); | ||
gen_test!( | ||
test_is_not_true, | ||
FunctionCall::new_unchecked( | ||
ExprType::IsNotTrue, | ||
vec![InputRef::new(0, DataType::Varchar).into()], | ||
DataType::Varchar | ||
) | ||
.into(), | ||
false | ||
); | ||
gen_test!( | ||
test_is_false, | ||
FunctionCall::new_unchecked( | ||
ExprType::IsFalse, | ||
vec![InputRef::new(0, DataType::Varchar).into()], | ||
DataType::Varchar | ||
) | ||
.into(), | ||
false | ||
); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.