feat(optimizer): support logical filter expression simplify rule

[xzhseh]

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR resolves the LogicalFilter simplification espeically under LogicalShare.

e.g., the rule will apply in LogicalFilter -> LogicalShare -> LogicalFilter.

close #14133.

Checklist

• I have written necessary rustdoc comments
• I have added necessary unit tests and integration tests
• I have added test labels as necessary. See details.
• I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
• My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
• All checks passed in ./risedev check (or alias, ./risedev c)
• My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

• My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

• My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

[xzhseh]

P.S. It's strange that only in StreamFilter (presumably in LogicalShare) will these kind of predicate exist, so the current implementation is essentially checking the input in LogicalShare, I have no idea why this is the case at present.

[st1page]

We have had some expressions simplify logic here and it could be called every time a new Condition is constructed.

risingwave/src/frontend/src/utils/condition.rs

Line 845 in d9228fc

fn simplify(self) -> Self {

I am not sure which one is better to organize the logic, implement them as a optimization rule or implement in Conditon.. but maybe we should maintain them in the same place 🤔

[xzhseh]

We have had some expressions simplify logic here and it could be called every time a new Condition is constructed.

risingwave/src/frontend/src/utils/condition.rs

Line 845 in d9228fc

fn simplify(self) -> Self {

I am not sure which one is better to organize the logic, implement them as a optimization rule or implement in Conditon.. but maybe we should maintain them in the same place 🤔

Thanks for pointing this out!
I haven't noticed this before and I'll take a look tomorrow. 😄

[xzhseh]

Now we only consider e that contains at most one column as the optimizable pattern, in Not(e) [op] e, if the column exists, it will be converted to IsNotNull(col) under specific context.
Two special patterns will be checked and try elimating first, e.g., true or (...) => true, false and (...) => false.
cc @chenzl25, @st1page.

[chenzl25]

Rest LGTM

[xzhseh]

Please correct me this is not intended for Share, i.e., rewrite input: RefCell<PlanRef>.
cc @chenzl25 @st1page.

[chenzl25]

Rest LGTM

[chenzl25]

LGTM