Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: deprecate non all-in-one binary #15356

Merged
merged 2 commits into from
Feb 29, 2024
Merged

build: deprecate non all-in-one binary #15356

merged 2 commits into from
Feb 29, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Feb 29, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@BugenZhao
Copy link
Member

  • but not added for non all-in-one binary. This indicates that it may bring unnecessary trouble for us.

Shouldn't we still need to consider this for risectl after this PR? 😕

Comment on lines +48 to +49
set_env RISEDEV_CARGO_BUILD_CRATE "risingwave_cmd_all"
set_env RISEDEV_CTL_RUN_CMD "-- risectl"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can inline these variables.

@xxchan xxchan changed the title feat: deprecate non all-in-one binary build: deprecate non all-in-one binary Feb 29, 2024
@xxchan
Copy link
Member Author

xxchan commented Feb 29, 2024

  • but not added for non all-in-one binary. This indicates that it may bring unnecessary trouble for us.

Shouldn't we still need to consider this for risectl after this PR? 😕

risectl only requires minimal features, mainly some data types, so this is less likely a concern

@xxchan xxchan added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit 60ccc76 Feb 29, 2024
29 of 30 checks passed
@xxchan xxchan deleted the xxchan/all-in-one branch February 29, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants