build: deprecate non all-in-one binary

Makefile.toml

@@ -29,7 +29,6 @@ env_scripts = [
 set_env ENABLE_TELEMETRY "false"
 
 is_sanitizer_enabled = get_env ENABLE_SANITIZER
-is_all_in_one_enabled = get_env ENABLE_ALL_IN_ONE
 is_hdfs_backend = get_env ENABLE_HDFS
 is_release = get_env ENABLE_RELEASE_PROFILE
 is_not_release = not ${is_release}
@@ -46,13 +45,8 @@ else
   set_env RISEDEV_BUILD_TARGET_DIR ""
 end
 
-if ${is_all_in_one_enabled}
-  set_env RISEDEV_CARGO_BUILD_CRATE "risingwave_cmd_all"
-  set_env RISEDEV_CTL_RUN_CMD "-- risectl"
-else
-  set_env RISEDEV_CARGO_BUILD_CRATE "risingwave_cmd"
-  set_env RISEDEV_CTL_RUN_CMD "--bin risectl --"
-end
+set_env RISEDEV_CARGO_BUILD_CRATE "risingwave_cmd_all"
+set_env RISEDEV_CTL_RUN_CMD "-- risectl"
 
 if ${is_hdfs_backend}
   set_env BUILD_HDFS_BACKEND_CMD "-p risingwave_object_store --features hdfs-backend"
@@ -268,31 +262,10 @@ set -e
 python -mwebbrowser file://$(pwd)/target/doc/index.html
 '''
 
-[tasks.link-standalone-binaries]
-private = true
-category = "RiseDev - Build"
-description = "Link standalone cmds to RiseDev bin"
-condition = { env_not_set = ["ENABLE_ALL_IN_ONE"] }
-script = '''
-#!/usr/bin/env bash
-set -e
-rm -f "${PREFIX_BIN}/compute-node"
-rm -f "${PREFIX_BIN}/meta-node"
-rm -f "${PREFIX_BIN}/frontend"
-rm -f "${PREFIX_BIN}/compactor"
-rm -f "${PREFIX_BIN}/risectl"
-ln -s "$(pwd)/target/${RISEDEV_BUILD_TARGET_DIR}${BUILD_MODE_DIR}/compute-node" "${PREFIX_BIN}/compute-node"
-ln -s "$(pwd)/target/${RISEDEV_BUILD_TARGET_DIR}${BUILD_MODE_DIR}/meta-node" "${PREFIX_BIN}/meta-node"
-ln -s "$(pwd)/target/${RISEDEV_BUILD_TARGET_DIR}${BUILD_MODE_DIR}/frontend" "${PREFIX_BIN}/frontend"
-ln -s "$(pwd)/target/${RISEDEV_BUILD_TARGET_DIR}${BUILD_MODE_DIR}/compactor" "${PREFIX_BIN}/compactor"
-ln -s "$(pwd)/target/${RISEDEV_BUILD_TARGET_DIR}${BUILD_MODE_DIR}/risectl" "${PREFIX_BIN}/risectl"
-'''
-
 [tasks.link-all-in-one-binaries]
 private = true
 category = "RiseDev - Build"
 description = "Link all-in-one cmds to RiseDev bin"
-condition = { env_set = ["ENABLE_ALL_IN_ONE"] }
 script = '''
 #!/usr/bin/env bash
 set -e
@@ -339,13 +312,7 @@ script = '''
 #!/usr/bin/env bash
 set -e
 
-binaries=()
-
-if [[ "$ENABLE_ALL_IN_ONE" == "true" ]]; then
-  binaries=("risingwave")
-else
-  binaries=("meta-node" "compute-node" "frontend" "compactor")
-fi
+binaries=("risingwave")
 
 set -ex
 echo -n "${binaries[*]}" | parallel -d ' ' \
@@ -356,7 +323,6 @@ echo -n "${binaries[*]}" | parallel -d ' ' \
 private = true
 category = "RiseDev - Build"
 description = "Link all binaries to .bin"
-condition = { env_set = ["ENABLE_ALL_IN_ONE"] }
 script = '''
 #!/usr/bin/env bash
 set -e

backwards-compat-tests/scripts/run_local.sh

@@ -37,9 +37,6 @@ ENABLE_KAFKA=true
 # Fetch risingwave binary from release.
 ENABLE_BUILD_RUST=true
 
-# Ensure it will link the all-in-one binary from our release.
-ENABLE_ALL_IN_ONE=true
-
 # ENABLE_RELEASE_PROFILE=true
 EOF
 }

ci/risedev-components.ci.benchmark.env

@@ -1,7 +1,6 @@
 RISEDEV_CONFIGURED=true
 ENABLE_MINIO=true
 ENABLE_ETCD=true
-ENABLE_ALL_IN_ONE=true
 ENABLE_KAFKA=true
 ENABLE_BUILD_RUST=true
 ENABLE_RELEASE_PROFILE=true

ci/risedev-components.ci.env

@@ -1,4 +1,3 @@
 RISEDEV_CONFIGURED=true
 ENABLE_MINIO=true
 ENABLE_ETCD=true
-ENABLE_ALL_IN_ONE=true

ci/risedev-components.ci.source.env

@@ -1,6 +1,5 @@
 RISEDEV_CONFIGURED=true
 ENABLE_MINIO=true
 ENABLE_ETCD=true
-ENABLE_ALL_IN_ONE=true
 ENABLE_KAFKA=true
 ENABLE_PUBSUB=true

ci/scripts/backwards-compat-test.sh

@@ -61,9 +61,6 @@ ENABLE_KAFKA=true
 # Fetch risingwave binary from release.
 ENABLE_BUILD_RUST=false
 
-# Ensure it will link the all-in-one binary from our release.
-ENABLE_ALL_IN_ONE=true
-
 # Use target/debug for simplicity.
 ENABLE_RELEASE_PROFILE=false
 EOF
@@ -94,9 +91,6 @@ ENABLE_KAFKA=true
 # Make sure that it builds
 ENABLE_BUILD_RUST=true
 
-# Ensure it will link the all-in-one binary from our release.
-ENABLE_ALL_IN_ONE=true
-
 # Use target/debug for simplicity.
 ENABLE_RELEASE_PROFILE=false
 EOF

ci/scripts/gen-flamegraph.sh

@@ -159,7 +159,6 @@ ENABLE_KAFKA=true
 ENABLE_COMPUTE_TRACING=true
 ENABLE_BUILD_RUST=true
 ENABLE_RELEASE_PROFILE=true
-ENABLE_ALL_IN_ONE=true
 EOF
 popd
 }

src/cmd/Cargo.toml

@@ -52,26 +52,6 @@ task_stats_alloc = { path = "../utils/task_stats_alloc" }
 [lib]
 test = false
 
-[[bin]]
-name = "frontend"
-path = "src/bin/frontend_node.rs"
-test = false
-
-[[bin]]
-name = "meta-node"
-path = "src/bin/meta_node.rs"
-test = false
-
-[[bin]]
-name = "compute-node"
-path = "src/bin/compute_node.rs"
-test = false
-
-[[bin]]
-name = "compactor"
-path = "src/bin/compactor.rs"
-test = false
-
 [[bin]]
 name = "risectl"
 path = "src/bin/ctl.rs"

src/risedevtool/config/src/main.rs

@@ -70,7 +70,6 @@ pub enum Components {
     BuildConnectorNode,
     Dashboard,
     Release,
-    AllInOne,
     Sanitizer,
     DynamicLinking,
     HummockTrace,
@@ -92,7 +91,6 @@ impl Components {
             Self::Dashboard => "[Build] Dashboard",
             Self::Tracing => "[Component] Tracing: Grafana Tempo",
             Self::Release => "[Build] Enable release mode",
-            Self::AllInOne => "[Build] Enable all-in-one binary",
             Self::Sanitizer => "[Build] Enable sanitizer",
             Self::DynamicLinking => "[Build] Enable dynamic linking",
             Self::HummockTrace => "[Build] Hummock Trace",
@@ -148,12 +146,6 @@ you download Grafana Tempo."
             Self::Release => {
                 "
 Build RisingWave in release mode"
-            }
-            Self::AllInOne => {
-                "
-With this option enabled, RiseDev will help you create
-symlinks to `risingwave` all-in-one binary, so as to build
-and use `risingwave` in all-in-one mode."
             }
             Self::Sanitizer => {
                 "
@@ -212,7 +204,6 @@ As a result, RisingWave will dump the core on panics.
             "ENABLE_COMPUTE_TRACING" => Some(Self::Tracing),
             "ENABLE_RELEASE_PROFILE" => Some(Self::Release),
             "ENABLE_DYNAMIC_LINKING" => Some(Self::DynamicLinking),
-            "ENABLE_ALL_IN_ONE" => Some(Self::AllInOne),
             "ENABLE_SANITIZER" => Some(Self::Sanitizer),
             "ENABLE_REDIS" => Some(Self::Redis),
             "ENABLE_BUILD_RW_CONNECTOR" => Some(Self::BuildConnectorNode),
@@ -234,7 +225,6 @@ As a result, RisingWave will dump the core on panics.
             Self::Dashboard => "ENABLE_BUILD_DASHBOARD",
             Self::Tracing => "ENABLE_COMPUTE_TRACING",
             Self::Release => "ENABLE_RELEASE_PROFILE",
-            Self::AllInOne => "ENABLE_ALL_IN_ONE",
             Self::Sanitizer => "ENABLE_SANITIZER",
             Self::BuildConnectorNode => "ENABLE_BUILD_RW_CONNECTOR",
             Self::DynamicLinking => "ENABLE_DYNAMIC_LINKING",

src/risedevtool/src/task/compactor_service.rs

@@ -34,15 +34,9 @@ impl CompactorService {
     fn compactor(&self) -> Result<Command> {
         let prefix_bin = env::var("PREFIX_BIN")?;
 
-        if let Ok(x) = env::var("ENABLE_ALL_IN_ONE")
-            && x == "true"
-        {
-            Ok(Command::new(
-                Path::new(&prefix_bin).join("risingwave").join("compactor"),
-            ))
-        } else {
-            Ok(Command::new(Path::new(&prefix_bin).join("compactor")))
-        }
+        Ok(Command::new(
+            Path::new(&prefix_bin).join("risingwave").join("compactor"),
+        ))
     }
 
     /// Apply command args according to config

src/risedevtool/src/task/compute_node_service.rs

@@ -34,17 +34,11 @@ impl ComputeNodeService {
     fn compute_node(&self) -> Result<Command> {
         let prefix_bin = env::var("PREFIX_BIN")?;
 
-        if let Ok(x) = env::var("ENABLE_ALL_IN_ONE")
-            && x == "true"
-        {
-            Ok(Command::new(
-                Path::new(&prefix_bin)
-                    .join("risingwave")
-                    .join("compute-node"),
-            ))
-        } else {
-            Ok(Command::new(Path::new(&prefix_bin).join("compute-node")))
-        }
+        Ok(Command::new(
+            Path::new(&prefix_bin)
+                .join("risingwave")
+                .join("compute-node"),
+        ))
     }
 
     /// Apply command args according to config

src/risedevtool/src/task/frontend_service.rs

@@ -35,17 +35,11 @@ impl FrontendService {
     fn frontend(&self) -> Result<Command> {
         let prefix_bin = env::var("PREFIX_BIN")?;
 
-        if let Ok(x) = env::var("ENABLE_ALL_IN_ONE")
-            && x == "true"
-        {
-            Ok(Command::new(
-                Path::new(&prefix_bin)
-                    .join("risingwave")
-                    .join("frontend-node"),
-            ))
-        } else {
-            Ok(Command::new(Path::new(&prefix_bin).join("frontend")))
-        }
+        Ok(Command::new(
+            Path::new(&prefix_bin)
+                .join("risingwave")
+                .join("frontend-node"),
+        ))
     }
 
     /// Apply command args according to config

src/risedevtool/src/task/meta_node_service.rs

@@ -35,15 +35,9 @@ impl MetaNodeService {
     fn meta_node(&self) -> Result<Command> {
         let prefix_bin = env::var("PREFIX_BIN")?;
 
-        if let Ok(x) = env::var("ENABLE_ALL_IN_ONE")
-            && x == "true"
-        {
-            Ok(Command::new(
-                Path::new(&prefix_bin).join("risingwave").join("meta-node"),
-            ))
-        } else {
-            Ok(Command::new(Path::new(&prefix_bin).join("meta-node")))
-        }
+        Ok(Command::new(
+            Path::new(&prefix_bin).join("risingwave").join("meta-node"),
+        ))
     }
 
     /// Apply command args according to config