Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix backwards compat tests #15448

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Mar 5, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Broken in #15356. In older version of RisingWave, risedev will try to find the individual binaries for meta-node etc... so we just include that config to make sure it is linked, if it's in a older version.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@kwannoel kwannoel added ci/run-backwards-compat-tests Run backwards compatibility tests in your PR. ci/run-main-cron ci/run-build labels Mar 5, 2024
@kwannoel kwannoel force-pushed the kwannoel/fix-backwards-compat branch from 67485d6 to 99abed8 Compare March 5, 2024 07:46
@kwannoel kwannoel requested a review from xxchan March 5, 2024 08:09
@kwannoel kwannoel enabled auto-merge March 5, 2024 08:12
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, this is awkward. Thanks for the fix!

@kwannoel kwannoel added this pull request to the merge queue Mar 5, 2024
Merged via the queue into main with commit ee0ef0b Mar 5, 2024
30 of 31 checks passed
@kwannoel kwannoel deleted the kwannoel/fix-backwards-compat branch March 5, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-backwards-compat-tests Run backwards compatibility tests in your PR. ci/run-build type/chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants