Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ci): simplify sqlsmith workflow #12592

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Sep 29, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Disable frontend tests. They fail after Unsupported function: array(int32, int32, int32, int32) -> list #12577.
  • This will save cost, the frontend is still being fuzzed in main-cron, by the e2e fuzzing step.
  • Re-enable sqlsmith tests for Pull Requests which contain changes to sqlsmith source files.
  • Merge all sqlsmith workflows into main-cron.
    • Previously we separated it into sqlsmith-tests because sqlsmith is flaky sometimes, and we wanted to keep main-cron stable.
    • But I think we should merge it back to save costs (extra build step is required for sqlsmith tests).
    • Also easier to maintain just 2 instead of 3 workflows with sqlsmith.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@kwannoel kwannoel changed the title refactor(ci) refactor(ci): simplify sqlsmith workflow Sep 29, 2023
@kwannoel kwannoel requested review from lmatz and fuyufjh September 29, 2023 02:26
@kwannoel kwannoel marked this pull request as ready for review September 29, 2023 02:27
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwannoel kwannoel enabled auto-merge September 29, 2023 03:06
@kwannoel kwannoel added this pull request to the merge queue Sep 29, 2023
Merged via the queue into main with commit 31aac5a Sep 29, 2023
5 of 6 checks passed
@kwannoel kwannoel deleted the kwannoel/disable-frontend branch September 29, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants