Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupported function: array(int32, int32, int32, int32) -> list #12577

Closed
kwannoel opened this issue Sep 28, 2023 · 2 comments · Fixed by #12660
Closed

Unsupported function: array(int32, int32, int32, int32) -> list #12577

kwannoel opened this issue Sep 28, 2023 · 2 comments · Fixed by #12660
Assignees
Labels
found-by-sqlsmith type/bug Something isn't working
Milestone

Comments

@kwannoel
Copy link
Contributor

kwannoel commented Sep 28, 2023

Describe the bug

Frontend tests for sqlsmith fail. These tests call the respective components entrypoints: parser, binder, planner's, to test the frontend parts of query handling.

Seems to fail at main@ d583594
The commit before: 09a1dcb passes.

@wangrunji0408 could you PTAL? Is this expected after the expr refactor?

The query still works for me e2e.

(Perhaps we should just remove the sqlsmith frontend tests as the e2e tests should cover it)

Error message/log

thread 'main' panicked at src/tests/sqlsmith/tests/frontend/mod.rs:280:52:
called `Result::unwrap()` on an `Err` value: Failed { msg: Some("Error Reason:\nExpr error: Unsupported function: array(int32, int32, int32, int32) -> list") }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

To Reproduce

NEXTEST_PROFILE=ci cargo nextest run --package risingwave_sqlsmith --features "enable_sqlsmith_unit_test"

query:

CREATE TABLE alltypes1 (
    c1 boolean,
    c2 smallint,
    c3 integer,
    c4 bigint,
    c5 real,
    c6 double precision,
    c7 numeric,
    c8 date,
    c9 varchar,
    c10 time without time zone,
    c11 timestamp without time zone,
    -- TODO(Noel): Many timestamptz expressions are unsupported in RW, leave this out for now.
    -- c12 timestamp with time zone,
    c13 interval,
    c14 struct < a integer >,
    c15 integer [],
    c16 varchar []
);


CREATE MATERIALIZED VIEW m4 AS SELECT t_4.c5 AS col_0, (ARRAY[(INT '850'), (INT '0'), (INT '34'), (INT '-2147483648')]) AS col_1, t_4.c15 AS col_2 FROM alltypes1 AS t_4 GROUP BY t_4.c10, t_4.c7, t_4.c13, t_4.c11, t_4.c3, t_4.c9, t_4.c5, t_4.c15 HAVING false ORDER BY t_4.c15 NULLS LAST;

Expected behavior

No response

How did you deploy RisingWave?

No response

The version of RisingWave

No response

Additional context

No response

@kwannoel kwannoel added type/bug Something isn't working found-by-sqlsmith labels Sep 28, 2023
@github-actions github-actions bot added this to the release-1.3 milestone Sep 28, 2023
@kwannoel kwannoel changed the title function: array(int32, int32, int32, int32) -> list Unsupported function: array(int32, int32, int32, int32) -> list Sep 29, 2023
@kwannoel
Copy link
Contributor Author

Worked around in #12592 . But still wonder why this can't be handled by frontend anymore. Is it expected?

@wangrunji0408
Copy link
Contributor

This is a bug, as explained in #12660. Sorry for the trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
found-by-sqlsmith type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants