Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): remove duplicated workflows in main-cron #12593

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Sep 29, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Seems like a bunch of workflows were duplicated in main-cron. Perhaps changes from #12233 and #12232 were duplicated because of slightly different test headings and different orderings.

> cat ci/workflows/main-cron.yml | grep label: | sort | sed -E 's/ \(release\)//' | uniq -c | grep '[2-9]  '
   2   - label: "S3 source check on AWS (json parser)"
   2   - label: "connector node integration test Java {{matrix.java_version}}"
   2   - label: "e2e java-binding test"
   2   - label: "end-to-end iceberg sink test"
   2   - label: "end-to-end iceberg sink v2 test"
   2   - label: "end-to-end test (parallel, in-memory)"

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@kwannoel kwannoel requested review from lmatz and fuyufjh September 29, 2023 02:45
@kwannoel kwannoel changed the title chore(ci): remove duplicated workflows chore(ci): remove duplicated workflows in main-cron Sep 29, 2023
@@ -478,7 +442,7 @@ steps:
config: ci/docker-compose.yml
mount-buildkite-agent: true
- ./ci/plugins/upload-failure-logs
timeout_in_minutes: 21
timeout_in_minutes: 25
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timeout of standalone test bumped also.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is TLE in main-cron

Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! ❤️

@kwannoel kwannoel added this pull request to the merge queue Sep 29, 2023
@kwannoel kwannoel removed this pull request from the merge queue due to a manual request Sep 29, 2023
@kwannoel
Copy link
Contributor Author

kwannoel commented Sep 29, 2023

Screenshot 2023-09-29 at 11 50 43 AM

This PR seems to have resolved most of the issues with main-cron. Pr fuzz test should be fixed by #12592 . Looking at pulsar test.

@kwannoel kwannoel added this pull request to the merge queue Sep 29, 2023
Merged via the queue into main with commit 8cb1da4 Sep 29, 2023
21 of 22 checks passed
@kwannoel kwannoel deleted the kwannoel/bump-timeout branch September 29, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants