-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove git from prebuild and use PNC Konflux tooling #2328
Conversation
Skipping CI for Draft Pull Request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2328 +/- ##
============================================
+ Coverage 43.86% 44.06% +0.20%
Complexity 785 785
============================================
Files 278 278
Lines 13290 13339 +49
Branches 1339 1339
============================================
+ Hits 5829 5878 +49
Misses 6867 6867
Partials 594 594 ☔ View full report in Codecov by Sentry. |
// Type: tektonpipeline.ParamTypeString, | ||
// StringVal: strings.Join(recipe.DisabledPlugins, ","), | ||
// }, | ||
//}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not ideal but now the prebuild is targeted at PNC not JBS and therefore the ability to dynamically remove plugins isn't available (plugin manipulation will be handled earlier in repour).
Value: tektonpipeline.ParamValue{ | ||
Type: tektonpipeline.ParamTypeString, | ||
StringVal: db.Spec.ScmInfo.CommitHash, | ||
StringVal: "quay.io/redhat-user-workloads/konflux-jbs-pnc-tenant/konflux-tooling:latest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit of hard-coding here - normally JVM_BUILD_SERVICE_REQPROCESSOR_IMAGE
is used but now prebuild is targeted at PNC and uses the separate https://github.com/project-ncl/konflux-tooling project we need to split them out and hardcode this.
782d6e8
to
bfc2f8b
Compare
54a1f8d
to
12221ec
Compare
371d8d8
to
6688bc2
Compare
@rnc: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR: