Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove git from prebuild and use PNC Konflux tooling #2328

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

rnc
Copy link
Collaborator

@rnc rnc commented Dec 19, 2024

This PR:

  • simplifies current pre-build by removing git source functionality from it
  • Ensures the mw-pipeline sets a default of the PNC konflux tooling
  • keeps JBS current functionality by moving the git source commit into another task and tacking it onto the pipeline

Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.06%. Comparing base (1088a89) to head (782d6e8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2328      +/-   ##
============================================
+ Coverage     43.86%   44.06%   +0.20%     
  Complexity      785      785              
============================================
  Files           278      278              
  Lines         13290    13339      +49     
  Branches       1339     1339              
============================================
+ Hits           5829     5878      +49     
  Misses         6867     6867              
  Partials        594      594              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

// Type: tektonpipeline.ParamTypeString,
// StringVal: strings.Join(recipe.DisabledPlugins, ","),
// },
//},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal but now the prebuild is targeted at PNC not JBS and therefore the ability to dynamically remove plugins isn't available (plugin manipulation will be handled earlier in repour).

Value: tektonpipeline.ParamValue{
Type: tektonpipeline.ParamTypeString,
StringVal: db.Spec.ScmInfo.CommitHash,
StringVal: "quay.io/redhat-user-workloads/konflux-jbs-pnc-tenant/konflux-tooling:latest",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit of hard-coding here - normally JVM_BUILD_SERVICE_REQPROCESSOR_IMAGE is used but now prebuild is targeted at PNC and uses the separate https://github.com/project-ncl/konflux-tooling project we need to split them out and hardcode this.

@rnc rnc force-pushed the BR1 branch 3 times, most recently from 782d6e8 to bfc2f8b Compare December 23, 2024 14:40
@rnc rnc marked this pull request as ready for review December 23, 2024 14:40
@openshift-ci openshift-ci bot requested a review from vibe13 December 23, 2024 14:40
@rnc rnc force-pushed the BR1 branch 5 times, most recently from 54a1f8d to 12221ec Compare December 24, 2024 16:06
@rnc rnc requested review from matejonnet and tecarter94 and removed request for vibe13 December 24, 2024 16:40
@rnc rnc force-pushed the BR1 branch 2 times, most recently from 371d8d8 to 6688bc2 Compare January 13, 2025 14:02
Copy link
Contributor

openshift-ci bot commented Jan 13, 2025

@rnc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/jvm-build-service-in-repo-e2e 6688bc2 link true /test jvm-build-service-in-repo-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rnc rnc merged commit 3c696ce into redhat-appstudio:main Jan 13, 2025
21 of 22 checks passed
@rnc rnc deleted the BR1 branch January 13, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant