Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red Hat Konflux purge domain-proxy #2329

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Conversation

red-hat-konflux[bot]
Copy link
Contributor

@red-hat-konflux red-hat-konflux bot commented Dec 20, 2024

Pipelines as Code configuration removal

https://issues.redhat.com/browse/JBS-74

Signed-off-by: red-hat-konflux <[email protected]>
Copy link
Contributor

openshift-ci bot commented Dec 20, 2024

Hi @red-hat-konflux[bot]. Thanks for your PR.

I'm waiting for a redhat-appstudio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tecarter94 tecarter94 self-assigned this Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.86%. Comparing base (43cb638) to head (e192e64).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2329      +/-   ##
============================================
- Coverage     44.70%   43.86%   -0.85%     
  Complexity      785      785              
============================================
  Files           281      278       -3     
  Lines         13784    13290     -494     
  Branches       1339     1339              
============================================
- Hits           6162     5829     -333     
+ Misses         6996     6867     -129     
+ Partials        626      594      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnc
Copy link
Collaborator

rnc commented Dec 20, 2024

@tecarter94 What is the reason for this?

@rnc
Copy link
Collaborator

rnc commented Dec 20, 2024

I suspect this might be the cause of PRs like #2331 failing. Initially I thought my PR ( #2328 ) was failing due to my mistakes but given the above is just a action version change with the same error I think not.
While I realise domain-proxy is also being installed elsewhere I was hoping to keep the minikube tests working for now until we have better CI in place in future.

@tecarter94
Copy link
Contributor

@tecarter94 What is the reason for this?

It wouldn't let me create a new component under PNC with the name "domain-proxy" without deleting this one first. Hadn't realised it would break things before being merged. My bad.

@rnc
Copy link
Collaborator

rnc commented Dec 20, 2024

@tecarter94 What is the reason for this?

It wouldn't let me create a new component under PNC with the name "domain-proxy" without deleting this one first. Hadn't realised it would break things before being merged. My bad.

Really? Ugh. This makes no sense. I might need to try and get some help here. After all one should be under jvm-build-service/domain-proxy and one should be under pnc/domain-proxy.

@tecarter94
Copy link
Contributor

tecarter94 commented Dec 20, 2024

@tecarter94 What is the reason for this?

It wouldn't let me create a new component under PNC with the name "domain-proxy" without deleting this one first. Hadn't realised it would break things before being merged. My bad.

Really? Ugh. This makes no sense. I might need to try and get some help here. After all one should be under jvm-build-service/domain-proxy and one should be under pnc/domain-proxy.

I'll have a go at getting things working on the JBS side again once I get home.

@rnc
Copy link
Collaborator

rnc commented Dec 20, 2024

@tecarter94 What is the reason for this?

It wouldn't let me create a new component under PNC with the name "domain-proxy" without deleting this one first. Hadn't realised it would break things before being merged. My bad.

Really? Ugh. This makes no sense. I might need to try and get some help here. After all one should be under jvm-build-service/domain-proxy and one should be under pnc/domain-proxy.

I'll have a go at getting things working on the JBS side again once I get home.

No worries. I see what you mean - am am also getting alert:components.appstudio.redhat.com "domain-proxy" already exists when attempting to add the component (back) to jvm-build-service. I'm going to post a message to konflux-users forum (on slack) to get some help.

@rnc
Copy link
Collaborator

rnc commented Dec 20, 2024

@tecarter94 What is the reason for this?

It wouldn't let me create a new component under PNC with the name "domain-proxy" without deleting this one first. Hadn't realised it would break things before being merged. My bad.

Really? Ugh. This makes no sense. I might need to try and get some help here. After all one should be under jvm-build-service/domain-proxy and one should be under pnc/domain-proxy.

I'll have a go at getting things working on the JBS side again once I get home.

No worries. I see what you mean - am am also getting alert:components.appstudio.redhat.com "domain-proxy" already exists when attempting to add the component (back) to jvm-build-service. I'm going to post a message to konflux-users forum (on slack) to get some help.

@tecarter94
Konflux support state you're correct that the naming will clash. I wonder if we can get the domain-proxy building and the images generated in https://github.com/project-ncl/domain-proxy first, and then migrate any references in 'here' to use that instead?

@tecarter94
Copy link
Contributor

@tecarter94 What is the reason for this?

It wouldn't let me create a new component under PNC with the name "domain-proxy" without deleting this one first. Hadn't realised it would break things before being merged. My bad.

Really? Ugh. This makes no sense. I might need to try and get some help here. After all one should be under jvm-build-service/domain-proxy and one should be under pnc/domain-proxy.

I'll have a go at getting things working on the JBS side again once I get home.

No worries. I see what you mean - am am also getting alert:components.appstudio.redhat.com "domain-proxy" already exists when attempting to add the component (back) to jvm-build-service. I'm going to post a message to konflux-users forum (on slack) to get some help.

@tecarter94 Konflux support state you're correct that the naming will clash. I wonder if we can get the domain-proxy building and the images generated in https://github.com/project-ncl/domain-proxy first, and then migrate any references in 'here' to use that instead?

That was definitely my aim for Monday once I got konflux integrated with the new repo. Feel free to delete the PNC component I created and recreate the JBS one for now.

@tecarter94 tecarter94 force-pushed the konflux-purge-domain-proxy branch from 5798cd4 to e192e64 Compare December 23, 2024 01:55
@tecarter94 tecarter94 merged commit 1088a89 into main Dec 23, 2024
22 checks passed
@tecarter94 tecarter94 deleted the konflux-purge-domain-proxy branch December 23, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants