-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Red Hat Konflux purge domain-proxy #2329
Conversation
Signed-off-by: red-hat-konflux <[email protected]>
Hi @red-hat-konflux[bot]. Thanks for your PR. I'm waiting for a redhat-appstudio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2329 +/- ##
============================================
- Coverage 44.70% 43.86% -0.85%
Complexity 785 785
============================================
Files 281 278 -3
Lines 13784 13290 -494
Branches 1339 1339
============================================
- Hits 6162 5829 -333
+ Misses 6996 6867 -129
+ Partials 626 594 -32 ☔ View full report in Codecov by Sentry. |
@tecarter94 What is the reason for this? |
I suspect this might be the cause of PRs like #2331 failing. Initially I thought my PR ( #2328 ) was failing due to my mistakes but given the above is just a action version change with the same error I think not. |
It wouldn't let me create a new component under PNC with the name "domain-proxy" without deleting this one first. Hadn't realised it would break things before being merged. My bad. |
Really? Ugh. This makes no sense. I might need to try and get some help here. After all one should be under jvm-build-service/domain-proxy and one should be under pnc/domain-proxy. |
I'll have a go at getting things working on the JBS side again once I get home. |
No worries. I see what you mean - am am also getting |
@tecarter94 |
That was definitely my aim for Monday once I got konflux integrated with the new repo. Feel free to delete the PNC component I created and recreate the JBS one for now. |
5798cd4
to
e192e64
Compare
Pipelines as Code configuration removal
https://issues.redhat.com/browse/JBS-74