Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of migrated code. Renaming. #2336

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Removal of migrated code. Renaming. #2336

merged 4 commits into from
Jan 14, 2025

Conversation

rnc
Copy link
Collaborator

@rnc rnc commented Jan 9, 2025

For JBS-79. Will require rebasing once #2328 is merged. Related to project-ncl/konflux-tooling#15

Copy link
Contributor

openshift-ci bot commented Jan 9, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.26%. Comparing base (c416257) to head (35736e2).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2336      +/-   ##
============================================
- Coverage     43.86%   42.26%   -1.60%     
+ Complexity      785      765      -20     
============================================
  Files           278      241      -37     
  Lines         13290     8234    -5056     
  Branches       1339     1328      -11     
============================================
- Hits           5829     3480    -2349     
+ Misses         6867     4364    -2503     
+ Partials        594      390     -204     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnc rnc marked this pull request as ready for review January 13, 2025 16:31
@openshift-ci openshift-ci bot requested a review from vibe13 January 13, 2025 16:31
@rnc rnc force-pushed the JBS79 branch 2 times, most recently from 6714436 to d56bf28 Compare January 13, 2025 16:57
@rnc rnc changed the title Removal of migrated code. Remaming. Removal of migrated code. Renaming. Jan 13, 2025
@rnc rnc requested review from matejonnet and removed request for vibe13 January 13, 2025 19:40
Copy link
Contributor

openshift-ci bot commented Jan 14, 2025

@rnc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/jvm-build-service-in-repo-e2e f01986a link true /test jvm-build-service-in-repo-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rnc rnc merged commit fe8692b into redhat-appstudio:main Jan 14, 2025
21 of 22 checks passed
@rnc rnc deleted the JBS79 branch January 14, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant