Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip the benchmark ctests within CI #4522

Merged

Conversation

ChuckHastings
Copy link
Collaborator

@ChuckHastings ChuckHastings commented Jul 5, 2024

We have been hitting OOM failures in CI due to some tests using larger amounts of memory. Our C++ testing includes benchmark tests that allow us to test on larger data sets.

This PR will suppress execution of the benchmark tests within CI. Disabling these tests shouldn't reduce code coverage in testing. They are mainly used for developers to test larger scale graphs and see the impact on performance of different updates we make. We plan on adding these to our nightly tests where we will probably only run the benchmark results, perhaps with larger data sets since we'll run serially on larger GPUs.

Also updated dependencies to skip cmake version 3.30.0

@github-actions github-actions bot added the ci label Jul 5, 2024
@ChuckHastings ChuckHastings self-assigned this Jul 5, 2024
@ChuckHastings ChuckHastings added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed ci labels Jul 5, 2024
@ChuckHastings ChuckHastings added this to the 24.08 milestone Jul 5, 2024
@ChuckHastings ChuckHastings marked this pull request as ready for review July 5, 2024 16:06
@ChuckHastings ChuckHastings requested a review from a team as a code owner July 5, 2024 16:06
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This !=3.30.0 constraint on CMake should be added in all the conda recipes using CMake as well.

e.g.

cmake_version:
- ">=3.26.4"
and others in conda/recipes/

Approving so you don't need to wait on another review from me after addressing that.

@ChuckHastings
Copy link
Collaborator Author

This !=3.30.0 constraint on CMake should be added in all the conda recipes using CMake as well.

e.g.

cmake_version:
- ">=3.26.4"

and others in conda/recipes/
Approving so you don't need to wait on another review from me after addressing that.

So these files aren't managed by the dependency generator. I have updated them.

@naimnv
Copy link
Contributor

naimnv commented Jul 6, 2024

/merge

@rapids-bot rapids-bot bot merged commit 42c7ad7 into rapidsai:branch-24.08 Jul 6, 2024
137 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants