-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip the benchmark ctests within CI #4522
Skip the benchmark ctests within CI #4522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This !=3.30.0
constraint on CMake should be added in all the conda recipes using CMake as well.
e.g.
cugraph/conda/recipes/cugraph/conda_build_config.yaml
Lines 13 to 14 in b9001f9
cmake_version: | |
- ">=3.26.4" |
conda/recipes/
Approving so you don't need to wait on another review from me after addressing that.
So these files aren't managed by the dependency generator. I have updated them. |
/merge |
We have been hitting OOM failures in CI due to some tests using larger amounts of memory. Our C++ testing includes benchmark tests that allow us to test on larger data sets.
This PR will suppress execution of the benchmark tests within CI. Disabling these tests shouldn't reduce code coverage in testing. They are mainly used for developers to test larger scale graphs and see the impact on performance of different updates we make. We plan on adding these to our nightly tests where we will probably only run the benchmark results, perhaps with larger data sets since we'll run serially on larger GPUs.
Also updated dependencies to skip cmake version 3.30.0