Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip cmake 3.30.0 across RAPIDS #80

Closed
15 tasks done
jameslamb opened this issue Jul 5, 2024 · 1 comment
Closed
15 tasks done

skip cmake 3.30.0 across RAPIDS #80

jameslamb opened this issue Jul 5, 2024 · 1 comment
Assignees
@jameslamb

Comments

@jameslamb
Copy link
Member

jameslamb commented Jul 5, 2024 •
edited
Loading

Description

With the release of CMake 3.30.0, we started observing configure errors like the following across a couple RAPIDS projects:

-- Configuring done (13.1s)
CMake Error at CMakeLists.txt:669 (target_link_libraries):
  The link interface of target "raft_distributed" contains:

    ucx::ucp

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

(build link)

Until a v3.30.1 of CMake is released with a fix, RAPIDS libraries should skip v3.30.0, with pins like this:

cmake >=3.26.4,!=3.30.0

Benefits of this work

  • unblocks development across RAPIDS

Acceptance Criteria

  • CI is no longer blocked, in any RAPIDS repo, by this particular CMake issue

Approach

Use rapids-reviser, add a !=3.30.0 pin to all the CMake pins.

Notes

Using a != is preferable to a ceiling here, because:

  • no need to do another round of updates once a v3.30.1 with a fix is released
  • reduces the risk of getting v3.30.0 during development in the future

Identified the repos that need this via this GitHub search: https://github.com/search?q=org%3Arapidsai%20%22cmake%3E%3D%22%20AND%20NOT%20is%3Aarchived&type=code

Tasks
Preview Give feedback
This was referenced Jul 5, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this issue Jul 5, 2024
@jameslamb
skip CMake 3.30.0 (#5956)
d82895f 
Contributes to rapidsai/build-planning#80

Adds constraints to avoid pulling in CMake 3.30.0, for the reasons described in that issue.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #5956
rapids-bot bot pushed a commit to rapidsai/kvikio that referenced this issue Jul 5, 2024
@jameslamb
skip CMake 3.30.0 (#400)
363e2d6 
Contributes to rapidsai/build-planning#80

Adds constraints to avoid pulling in CMake 3.30.0, for the reasons described in that issue.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #400
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this issue Jul 5, 2024
@jameslamb
skip CMake 3.30.0 (#16202)
f6b355d 
Contributes to rapidsai/build-planning#80

Adds constraints to avoid pulling in CMake 3.30.0, for the reasons described in that issue.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #16202
@jameslamb jameslamb self-assigned this Jul 5, 2024
rapids-bot bot pushed a commit to rapidsai/wholegraph that referenced this issue Jul 5, 2024
@jameslamb
skip CMake 3.30.0 (#189)
ef798c3 
Contributes to rapidsai/build-planning#80

Adds constraints to avoid pulling in CMake 3.30.0, for the reasons described in that issue.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #189
rapids-bot bot pushed a commit to rapidsai/rmm that referenced this issue Jul 5, 2024
@jameslamb
skip CMake 3.30.0 (#1603)
b8b67f8 
Contributes to rapidsai/build-planning#80

Adds constraints to avoid pulling in CMake 3.30.0, for the reasons described in that issue.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #1603
rapids-bot bot pushed a commit to rapidsai/cuvs that referenced this issue Jul 5, 2024
@jameslamb
skip CMake 3.30.0 (#214)
d814ed8 
Contributes to rapidsai/build-planning#80

Adds constraints to avoid pulling in CMake 3.30.0, for the reasons described in that issue.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ben Frederickson (https://github.com/benfred)
  - Bradley Dice (https://github.com/bdice)

URL: #214
rapids-bot bot pushed a commit to rapidsai/raft that referenced this issue Jul 5, 2024
@jameslamb
skip CMake 3.30.0 (#2375)
4d7a39c 
Contributes to rapidsai/build-planning#80

Adds constraints to avoid pulling in CMake 3.30.0, for the reasons described in that issue.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #2375
rapids-bot bot pushed a commit to rapidsai/ucxx that referenced this issue Jul 6, 2024
@jameslamb
skip CMake 3.30.0 (#244)
4f44a48 
Contributes to rapidsai/build-planning#80

Adds constraints to avoid pulling in CMake 3.30.0, for the reasons described in that issue.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Peter Andreas Entschev (https://github.com/pentschev)

URL: #244
AyodeAwe pushed a commit to rapidsai/pynvjitlink that referenced this issue Jul 8, 2024
@jameslamb @bdice
skip CMake 3.30.0 (#94)
7a0906c 
## Description

Contributes to rapidsai/build-planning#80

Adds constraints to avoid pulling in CMake 3.30.0, for the reasons
described in that issue.

Co-authored-by: Bradley Dice <[email protected]>
rapids-bot bot pushed a commit to rapidsai/cuspatial that referenced this issue Jul 9, 2024
@jameslamb
skip CMake 3.30.0 (#1401)
400cbe3 
Contributes to rapidsai/build-planning#80

Adds constraints to avoid pulling in CMake 3.30.0, for the reasons described in that issue.

Authors:
  - James Lamb (https://github.com/jameslamb)
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - Paul Taylor (https://github.com/trxcllnt)
  - Bradley Dice (https://github.com/bdice)

URL: #1401
@hcho3 hcho3 mentioned this issue Jul 9, 2024
Merged
rapids-bot bot pushed a commit to rapidsai/cucim that referenced this issue Jul 9, 2024
@jameslamb
skip CMake 3.30.0, require CMake >=3.26.4 (#745)
fbca7fa 
Contributes to rapidsai/build-planning#80

Adds constraints to avoid pulling in CMake 3.30.0, for the reasons described in that issue.

## Notes for Reviewers

Most of the rest of RAPIDS is using `cmake >=3.26.4`... but I didn't change the floor here to match that, because I didn't know if it was intentional that `cucim` allows a wider range of `cmake` versions.

Let me know if you'd prefer I bump the `cmake` minimum version to `3.26.4` as part of this.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)
  - Gregory Lee (https://github.com/grlee77)

URL: #745
@jakirkham
Copy link
Member

With the exception of cuGraph-PG, which is covered in this comment ( rapidsai/cugraph-pg#23 (comment) ), these are complete. Let's close this out. Thanks James! 🙏

@jameslamb jameslamb mentioned this issue Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jameslamb jameslamb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakirkham @jameslamb