Skip to content

Commit

Permalink
Skip the benchmark ctests within CI (#4522)
Browse files Browse the repository at this point in the history
We have been hitting OOM failures in CI due to some tests using larger amounts of memory.  Our C++ testing includes benchmark tests that allow us to test on larger data sets.

This PR will suppress execution of the benchmark tests within CI.  Disabling these tests shouldn't reduce code coverage in testing.  They are mainly used for developers to test larger scale graphs and see the impact on performance of different updates we make.  We plan on adding these to our nightly tests where we will probably only run the benchmark results, perhaps with larger data sets since we'll run serially on larger GPUs.

Also updated dependencies to skip cmake version 3.30.0

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - James Lamb (https://github.com/jameslamb)
  - Naim (https://github.com/naimnv)

URL: #4522
  • Loading branch information
ChuckHastings authored Jul 6, 2024
1 parent b9001f9 commit 42c7ad7
Show file tree
Hide file tree
Showing 10 changed files with 12 additions and 9 deletions.
3 changes: 3 additions & 0 deletions ci/test_cpp.sh
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ popd

export GTEST_OUTPUT=xml:${RAPIDS_TESTS_DIR}/

# Skip benchmark tests inside of CI
export GTEST_FILTER="-*benchmark*"

# Run libcugraph gtests from libcugraph-tests package
rapids-logger "Run gtests"
./ci/run_ctests.sh -j10 && EXITCODE=$? || EXITCODE=$?;
Expand Down
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-118_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ dependencies:
- aiohttp
- breathe
- c-compiler
- cmake>=3.26.4
- cmake>=3.26.4,!=3.30.0
- cuda-nvtx
- cuda-version=11.8
- cudatoolkit
Expand Down
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-122_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ dependencies:
- aiohttp
- breathe
- c-compiler
- cmake>=3.26.4
- cmake>=3.26.4,!=3.30.0
- cuda-cudart-dev
- cuda-nvcc
- cuda-nvtx-dev
Expand Down
2 changes: 1 addition & 1 deletion conda/recipes/cugraph-pyg/conda_build_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ cuda_compiler:
- nvcc

cmake_version:
- ">=3.26.4"
- ">=3.26.4,!=3.30.0"

c_stdlib:
- sysroot
Expand Down
2 changes: 1 addition & 1 deletion conda/recipes/cugraph/conda_build_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ cuda11_compiler:
- nvcc

cmake_version:
- ">=3.26.4"
- ">=3.26.4,!=3.30.0"

c_stdlib:
- sysroot
Expand Down
2 changes: 1 addition & 1 deletion conda/recipes/libcugraph/conda_build_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ cuda11_compiler:
- nvcc

cmake_version:
- ">=3.26.4"
- ">=3.26.4,!=3.30.0"

doxygen_version:
- ">=1.8.11"
Expand Down
2 changes: 1 addition & 1 deletion conda/recipes/pylibcugraph/conda_build_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ cuda11_compiler:
- nvcc

cmake_version:
- ">=3.26.4"
- ">=3.26.4,!=3.30.0"

c_stdlib:
- sysroot
Expand Down
2 changes: 1 addition & 1 deletion dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ dependencies:
common:
- output_types: [conda, pyproject]
packages:
- &cmake_ver cmake>=3.26.4
- &cmake_ver cmake>=3.26.4,!=3.30.0
- ninja
cpp_build:
common:
Expand Down
2 changes: 1 addition & 1 deletion python/cugraph/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ regex = "(?P<value>.*)"
[tool.rapids-build-backend]
build-backend = "scikit_build_core.build"
requires = [
"cmake>=3.26.4",
"cmake>=3.26.4,!=3.30.0",
"ninja",
"pylibcugraph==24.8.*,>=0.0.0a0",
"pylibraft==24.8.*,>=0.0.0a0",
Expand Down
2 changes: 1 addition & 1 deletion python/pylibcugraph/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ regex = "(?P<value>.*)"
build-backend = "scikit_build_core.build"
dependencies-file = "../../dependencies.yaml"
requires = [
"cmake>=3.26.4",
"cmake>=3.26.4,!=3.30.0",
"ninja",
"pylibraft==24.8.*,>=0.0.0a0",
"rmm==24.8.*,>=0.0.0a0",
Expand Down

0 comments on commit 42c7ad7

Please sign in to comment.