Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8769: introduce PackageInstance type to disambiguate from Metadata definition/instance use cases #8770

Merged
merged 18 commits into from
Jul 8, 2024

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Jul 7, 2024

What does this PR do?

Discussion

  • The Metadata and PackageInstance types are currently equivalent, so this change only provides readability improvements, but no enforcement

Future Work

  • Rename brickModalNoTags and related code to use package terminology

For more information on our expectations for the PR process, see the
code review principles doc

@twschiller twschiller changed the base branch from main to feature/8761-workshop-naming July 7, 2024 13:21
@twschiller twschiller added the do not merge Merging of this PR is blocked by another one label Jul 7, 2024
@twschiller twschiller requested a review from grahamlangford July 7, 2024 13:21
@twschiller twschiller self-assigned this Jul 7, 2024
@twschiller twschiller added this to the 2.0.5 milestone Jul 7, 2024
@twschiller twschiller changed the title #8769: introduce PackageInstance type to disambiguate from Metadata use cases #8769: introduce PackageInstance type to disambiguate from Metadata use cases Jul 7, 2024
Copy link

github-actions bot commented Jul 7, 2024

Playwright test results

passed  82 passed
flaky  2 flaky
skipped  2 skipped

Details

report  Open report ↗︎
stats  86 tests across 30 suites
duration  13 minutes, 12 seconds
commit  08a079f

Flaky tests

chrome › tests/regressions/welcomeStarterBricks.spec.ts › #8740: can view the starter mods on the pixiebrix.com/welcome page
edge › tests/regressions/welcomeStarterBricks.spec.ts › #8740: can view the starter mods on the pixiebrix.com/welcome page

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
edge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

@twschiller twschiller changed the title #8769: introduce PackageInstance type to disambiguate from Metadata use cases #8769: introduce PackageInstance type to disambiguate from Metadata definition/instance use cases Jul 7, 2024
Copy link

github-actions bot commented Jul 8, 2024

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

Base automatically changed from feature/8761-workshop-naming to main July 8, 2024 15:54
@twschiller twschiller removed the do not merge Merging of this PR is blocked by another one label Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.

Project coverage is 74.24%. Comparing base (8318d74) to head (08a079f).
Report is 26 commits behind head on main.

Files Patch % Lines
...es/packageEditor/referenceTab/PackageReference.tsx 0.00% 3 Missing ⚠️
src/components/brickModalNoTags/BrickModal.tsx 0.00% 2 Missing ⚠️
src/components/brickModalNoTags/BrickResult.tsx 0.00% 1 Missing ⚠️
src/components/brickModalNoTags/QuickAdd.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8770   +/-   ##
=======================================
  Coverage   74.24%   74.24%           
=======================================
  Files        1332     1332           
  Lines       40817    40857   +40     
  Branches     7634     7640    +6     
=======================================
+ Hits        30306    30336   +30     
- Misses      10511    10521   +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twschiller twschiller merged commit 5723114 into main Jul 8, 2024
18 checks passed
@twschiller twschiller deleted the feature/8769-package-instance branch July 8, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Use separate type names for Metadata use cases
2 participants