-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#8769: introduce PackageInstance
type to disambiguate from Metadata
definition/instance use cases
#8770
Conversation
PackageInstance
type to disambiguate from Metadata
use cases
Playwright test resultsDetails Open report ↗︎ Flaky testschrome › tests/regressions/welcomeStarterBricks.spec.ts › #8740: can view the starter mods on the pixiebrix.com/welcome page Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
PackageInstance
type to disambiguate from Metadata
use casesPackageInstance
type to disambiguate from Metadata
definition/instance use cases
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
…feature/8769-package-instance
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8770 +/- ##
=======================================
Coverage 74.24% 74.24%
=======================================
Files 1332 1332
Lines 40817 40857 +40
Branches 7634 7640 +6
=======================================
+ Hits 30306 30336 +30
- Misses 10511 10521 +10 ☔ View full report in Codecov by Sentry. |
What does this PR do?
Metadata
use cases #8769brick
topackage
in the Workshop #8762. Review/merge that PR firstDiscussion
Metadata
andPackageInstance
types are currently equivalent, so this change only provides readability improvements, but no enforcementFuture Work
For more information on our expectations for the PR process, see the
code review principles doc