Rename brickModalNoTags and BrickIcon to use package terminology

[twschiller]

What does this PR do?

• Rename brickModalNoTags to packageSearchModal to clarify its usage
• Rename BrickIcon to PackageIcon to clarify its usage
• FLUP to #8769: introduce PackageInstance type to disambiguate from Metadata definition/instance use cases #8770

Discussion

• Does the team prefer T vs. Instance vs. TInstance? T might be easier to read if there's a single generic type argument
• There's some places where we have generics that we don't really need generics. Generics are only really useful to correlate types (between parameters, or with the return value)

For more information on our expectations for the PR process, see the
code review principles doc

[codecov]

Codecov Report

Attention: Patch coverage is 32.00000% with 34 lines in your changes missing coverage. Please review.

Project coverage is 74.24%. Comparing base (8318d74) to head (0828798).
Report is 34 commits behind head on main.

Files	Patch %	Lines
...mponents/packageSearchModal/PackageSearchModal.tsx	0.00%	25 Missing ⚠️
...rc/components/packageSearchModal/PackageDetail.tsx	0.00%	3 Missing ⚠️
...rc/components/packageSearchModal/PackageResult.tsx	0.00%	3 Missing ⚠️
src/components/packageSearchModal/QuickAdd.tsx	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8773      +/-   ##
==========================================
- Coverage   74.24%   74.24%   -0.01%     
==========================================
  Files        1332     1332              
  Lines       40817    40866      +49     
  Branches     7634     7642       +8     
==========================================
+ Hits        30306    30339      +33     
- Misses      10511    10527      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Playwright test results

 84 passed
 2 flaky
 2 skipped

Details

 Open report ↗︎
 88 tests across 31 suites
 14 minutes, 30 seconds
 0828798

Flaky tests

edge › tests/pageEditor/saveMod.spec.ts › can save a standalone trigger mod
edge › tests/regressions/welcomeStarterBricks.spec.ts › #8740: can view the starter mods on the pixiebrix.com/welcome page

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
edge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

[github-actions]

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.